Support .consul in go-dnsmasq stubzones about docker-alpine HOT 5 CLOSED

@matthewvalimaki, yeah this looks good. I'm half way through approving and checking #13, post that, we can integrate this for sure. Nice and simple ;)

from docker-alpine.

Sweet. I have not looked into this but there was significant delay with
response when consul was only nameserver. Perhaps I missed an option,
perhaps newer consul doesn't experience that. Something to test :)
On Mar 17, 2016 3:55 PM, "Scott Mebberson" [email protected] wrote:

@matthewvalimaki https://github.com/matthewvalimaki, yeah this looks
good. I'm half way through approving and checking #13
#13, post that, we can
integrate this for sure. Nice and simple ;)

—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#31 (comment)

from docker-alpine.

Actually I propose we'll introduce ENV CONSUL_DOMAIN=consul to alpine-base which then is used with go-dnsmasq --stubzones=$CONSUL_DOMAIN/127.0.0.1:8600 and consul -domain $CONSUL_DOMAIN. That way it's easy to change it if necessary and no need to write over default /etc/services.d/consul/run.

from docker-alpine.

@matthewvalimaki, sounds good. I really like that refinement. If you want to implement in PR #34, I'll merge straight away :)

from docker-alpine.

@smebberson done. I also updated the ENV styling a bit to be more readable. I also updated go-dnsmasq version to latest while I was touching that spot.

So with this configuration we still default to consul domain and all should work as they used to. But if you want/need to change the domain all one needs to do is re-declare ENV CONSUL_DOMAIN=<my domain>.

from docker-alpine.