pfg file field causes crash in Plone 4.2.2 about products.ploneformgen HOT 6 CLOSED

I could solve the problem by downgrading Products.Archetypes to 1.8.3. Plone 4.2.2 installed Archetypes 1.8.4 by default. Not sure if this pinning has other side effects, at least my form runs fine again.

from products.ploneformgen.

Products.Archetypes.Field.FileField._make_file blindly passes the PFGFileField into constructor.
This is kinda interesting in that.. Why cant you get to the data of the PFGFile easily? It seems you
need to know the name of the field id to access the value..

Patching _make_file with the below works.. This is certainly a problem with AT I think

def _pfg_make_file(self, id, title='', file='', instance=None):
    """File content factory. Awful practice passing in a builtin, file in signature"""
    if getattr(file, 'seek', None) is None:
        logger.info("%s does not have seek method using empty string as value" % file)
        file = ''
    return self.content_class(id, title, file)

from products.ploneformgen.

This part has never changed before. What has changed in 1.8.4 was that a mimetype icon gets added. This triggers the make file code which wasnt triggered before.
It seems wrong to me that Archetypes gets a Products.PloneFormGen.content.fields.FGFileField object which is a schema but nothing file like.
I opted to add these methods to FGFileField:

def seek(self, offset, whence=None):
    return

def read(self, size=None):
    return ''

def tell(self):
    return 0

Since the FGFileField is not in risk being used as a file for an uploaded file, I believe this to be pretty safe.

from products.ploneformgen.

I can confirm that the patch provided by runyaga works. I rebuild my testinstance with Archetypes 1.8.4 to reproduce the error. When I applied the patch to /buildout-cache/eggs/Products.Archetypes-1.8.4-py2.7.egg/Products/Archetypes/Field.py the error was gone.

Applying the other patch from do3cc solves the problem as well. I am not sure if custom validators on file fields might be affected if they make use of the methods involved. Is the assumption "Since the FGFileField is not in risk being used as a file..." correct?

from products.ploneformgen.

I can't really tell. In only feel pretty confident that my patch would not worse the situation. A PGFileField never behaved like a File like object, so if anybody expected that would have failed before the change too.
Because I can't really tell I am not going to try to fix it myself.

from products.ploneformgen.

I've done a quick test, and the validation still works fine with do3cc's patch (thanks!)
Since I needed this for a project, I've forked the repo and will do a pull request
https://github.com/huubbouma/Products.PloneFormGen

from products.ploneformgen.