Git Product home page Git Product logo

Comments (7)

msinn avatar msinn commented on July 24, 2024

When usinig SmartHomeNG without Docker, SmartHomeNG starts without any problems even if there is no etc/logging.yaml. In that case, etc/logging.yaml.default is copied to etc/logging.yaml SmartHomeNG starts as usual

It must be a problem in your (Docker-)configuration that prevents SmartHomeNG to copy the file.

from smarthome.

AAPohl avatar AAPohl commented on July 24, 2024

Thank you for the info. I will look in that direction

from smarthome.

AAPohl avatar AAPohl commented on July 24, 2024

I did some debugging. I think I got the bug:

I use a custom conf_dir with parameter --config_dir /mnt/conf

lib/smarthome.py Line 218 - 251 ensures, as you mention, all config files beeing copied from ".default". In my case for /mnt/conf (with /usr/local/smarthome/etc as source)
Important: self._etc_dir is modified in Line 237 to /mnt/conf.

However, Line 211 (earlier) a instance of Log is created, that reads etc_dir in Line 66 stil to /usr/local/smarthome/etc.

Later, when configure_logging is called, that is not updated.

I suggest to move Line 66 lazy into the function that need it, as it is mutable.

from smarthome.

AAPohl avatar AAPohl commented on July 24, 2024

master...AAPohl:smarthomeLoggingFix:master

It works with these modifications

from smarthome.

Morg42 avatar Morg42 commented on July 24, 2024

Fix looks basically fine, but absolutely not merging into master... ;). please create a new PR from a develop based branch to develop.

from smarthome.

AAPohl avatar AAPohl commented on July 24, 2024

Sorry for that. Made a new PR into develop

from smarthome.

Morg42 avatar Morg42 commented on July 24, 2024

Merged fix.

from smarthome.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.