New Plugin Multi-Instance System: get_instance_name() not available in __init__ method of plugin about smarthome HOT 5 CLOSED

i rewrote my plugin to use the information from run method only.
anyway, i still think its not perfect that the information is only available outside the init method.

from smarthome.

i changed the plugin creation mechanism to set the instance name before call the __init__ method. please test it.

smartpugin uses now multiple inheritance to get the methods from Utils.py
now you can call self.is_float(...)

from smarthome.

an other issue: I can create for every plugin config attribute implicit a member inside the plugin object.

[plugin1]
   class_name = foo
   class_path = plugins.bla
   test = test1
   foo = bar 
   bar = foo

and inside the plugin you can get the values with self.foo or self.test
so we can change in future the __init__ signature to __init__() without params.
could it be useful?

from smarthome.

my issue can be closed, keeping this open due to last question of cstrassburg.

from my point of view, this could be useful yes. but init with params should be kept alive due to backward compatibility

from smarthome.

from my point of view, this could be useful yes. but init with params should be kept alive due to
backward compatibility

Just a few notes no plugin parameters: I was thinking about to change the signature completely for the init method: having just one args argument containing a dict with all configured parameters (see also #27).

Putting all parameters directly into member fields may be a bad idea since it could overwrite fields without notice (one could accidentally overwrite a field which is not a configuration parameter but an internal variable which should not be change from outside). And the plugin should take care explicitly which parameter it is using and which not.

@cstrassburg, since the first problem about the instance name is solved already we could close this issue and talk about the plugin parameter handling in #27.

What do you think?

from smarthome.