Comments (2)
I agree with proposed solution, however would like to clarify the following points.
- Does this mean our AWS deployment will have a separate config file?
- I suggest we could also add this as a unit test.
from cognicity-server.
- Regarding AWS, there's no separate config file for the server, but there is a separate config file for Elastic Beanstalk. Wait until I have submitted the pull request (I need to test in an EB environment first) and then take a look and this will be clearer.
- We could but then you'd be introducing a separate npm module just for testing and also the proposed default config is guaranteed to pass. Also, I think unit testing should be for code, and not the presence of a directory.
from cognicity-server.
Related Issues (20)
- Unable to put robots.txt in / HOT 2
- Installation HOT 6
- server test failing if config.pg.conString is valid HOT 2
- getHistoricalCountByArea test fails in newer node versions HOT 15
- Column missing / wrong table used HOT 4
- Redirect v1 API HOT 1
- zooming out leaves blank page HOT 7
- jshint issues
- Reset time window HOT 3
- Code duplication in getReports(), getReport()
- Floodgauges API endpoint gives wrong timezone
- Time zone should be as configuration option HOT 1
- getReport() doesn't return all report metadata
- Server will fail silently if config.logger.logDirectory not available
- User management HOT 1
- Time window for tweets reset by BPBD retweet
- Store times of status changes HOT 1
- Investigate default language redirection
- Flood sensor API needs to calculate water depth HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from cognicity-server.