Git Product home page Git Product logo

Comments (3)

flosse avatar flosse commented on August 17, 2024 1

@seritools Thanks for reporting!
@uklotzde Thanks for fixing the problem so quickly!

The issue should be resolved now in v0.13.1

from tokio-modbus.

flosse avatar flosse commented on August 17, 2024

Here is an explanation of the Disconnect variant

tokio-modbus/src/frame/mod.rs

Lines 178 to 187 in 13fcb83

/// A poison pill for stopping the client service and to release
/// the underlying transport, e.g. for disconnecting from an
/// exclusively used serial port.
///
/// This is an ugly workaround, because `tokio-proto` does not
/// provide other means to gracefully shut down the `ClientService`.
/// Otherwise the bound transport is never freed as long as the
/// executor is active, even when dropping the Modbus client
/// context.
Disconnect,

that causes the panic here:

tokio-modbus/src/frame/mod.rs

Line 244 in 13fcb83

Disconnect => unreachable!(),

So the question is why is

tokio-modbus/src/frame/mod.rs

Line 222 in 13fcb83

pub const fn function_code(&self) -> FunctionCode {

called when it must not 🤔

from tokio-modbus.

flosse avatar flosse commented on August 17, 2024

Here we are:

tokio-modbus/src/service/rtu.rs

Lines 51 to 52 in 13fcb83

let disconnect = req == Request::Disconnect;
let req_function_code = req.function_code();

@uklotzde I think that disconnect needs to be checked before calling function_code() right?

from tokio-modbus.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.