Thank you for reporting issue.
Can you provide more details on your build environment? For example, OS, compiler version, etc.
This file is part of the EDKII base tool, and it is the same as EDKII repo. I guess it might be something to do with the supported compiler version.

from slimbootloader.

gcc (GCC) 8.2.1 20181215 (Red Hat 8.2.1-6)
Copyright (C) 2018 Free Software Foundation, Inc.
Fedora29

from slimbootloader.

I've checked EDKII it forces -Wno-stringop-truncation

from slimbootloader.

../BaseTools/Source/C/Makefiles/header.makefile
ifeq ($(DARWIN),Darwin)

assume clang or clang compatible flags on OS X

BUILD_CFLAGS = -MD -fshort-wchar -fno-strict-aliasing -Wall -Werror -Wno-deprecated-declarations -Wno-self-assign -Wno-unused-result -nostdlib -g
else
BUILD_CFLAGS = -MD -fshort-wchar -fno-strict-aliasing -Wall -Werror -Wno-deprecated-declarations -Wno-stringop-truncation -Wno-restrict -Wno-unused-result -nostdlib -g
endif

from slimbootloader.

Thank you for the information. We will take a look into it.

from slimbootloader.

I am using gcc 8.2.0 on Ubuntu18, but there is no compile error. Can you give more information here?
gcc -v
uname -a

Can you compile a single file as below?

cd BaseTools/Source/C/Common
With Wno-stringop-truncation
gcc -c -I .. -I ../Include/Common -I ../Include/ -I ../Include/IndustryStandard -I ../Common/ -I .. -I . -I ../Include/X64/ -MD -fshort-wchar -fno-strict-aliasing -Wall -Werror -Wno-deprecated-declarations -Wno-stringop-truncation -Wno-restrict -Wno-unused-result -nostdlib -g -O2 EfiUtilityMsgs.c -o EfiUtilityMsgs.o
Without Wno-stringop-truncation
gcc -c -I .. -I ../Include/Common -I ../Include/ -I ../Include/IndustryStandard -I ../Common/ -I .. -I . -I ../Include/X64/ -MD -fshort-wchar -fno-strict-aliasing -Wall -Werror -Wno-deprecated-declarations -Wno-restrict -Wno-unused-result -nostdlib -g
-O2 EfiUtilityMsgs.c -o EfiUtilityMsgs.o

Please share your information and the result.

from slimbootloader.

Confirmed this issue building BaseTools can be duplicated on Fedora 29 when building BaseTools @ f9397b3.

It looks like upstream EDK2 @ bac50df can build BaseTools without issues. After searching through EDK2 history--appears resolved by this commit: 1d212a8. Probably best to sync with upstream EDK2 soon.

from slimbootloader.

from slimbootloader.

I think I can apply this patch from edk2 looks like less overhead that switching to ubuntu :)

from slimbootloader.

Sure. Meanwhile we also plan to merge the EDK2 fix into Slim Bootloader.

from slimbootloader.

@tomasbw Please feel free to apply the patch. We will follow up next steps. Thanks.

from slimbootloader.

@tomasbw To follow up this issue, #91 has been merged. Can you try the latest code?

from slimbootloader.

The compilation works, there are some issues with the quality of the patches, but you probably just brought them from the EDKII. I left some comments.

from slimbootloader.

@tomasbw Right, it was brought from EDKII and we keep the original file format. We can use dos2unix, but it will convert entire file and make hard to diff the change.

from slimbootloader.

@tomasbw Let me close this issue. Please let us know if you have any other issues or feel free to open your concern. Thanks.

from slimbootloader.

Ok

from slimbootloader.