Comments (10)
I've put 0.10.0 up on crates.io now. Let me know if it fixes everything for your use case!
from staticvec.
+1
from staticvec.
Sorry guys, was busy with other stuff for a bit. Just noticed the automated tests were failing.
I'm going to attempt to find a workaround for this, as it seems probably not okay for me to just entirely remove all of the combination helpers for some unspecified amount of time considering they've been implemented in their current form and working perfectly for months at this point.
For the record I don't think I necessarily agree with this now being a compiler "error" in general, also. It's essentially saying, "simple compile-time addition of two must-be-known-at-compile-time-anyways usizes may fail", which while I guess is technically a possibility in theory would still indeed be caught at compile time and as such is not something that could lead to any kind of un-Rusty hard-to-notice runtime bugs.
I don't see who exactly in what exact scenario that PR is supposed to benefit.
from staticvec.
I'm not a rust contributor or anything,
but while on the one hand it kinda sucks because its a feature that's been working for months,
on the other hand - const generics are REALLY unstable and don't seem to be going towards stabilization anytime soon.
IIUC, this will be fixed somehow before the feature is stabilized, by allowing to specify bounds on const generics. Honestly, as a user of this library, I would rather get a "combinator"-less version of staticvec
that can work with the latest nightly, rather than being stuck on an older nightly.. but that's just me. Not to sound ungrateful, because I'm definitely grateful for the work you put into this library. :)
from staticvec.
Oh yeah, I for sure want to get it working ASAP. Like, today ASAP. I'm just legitimately not sure what the "appropriate" thing to do here is if I cannot find a workaround.
For example, I could easily just remove the combination helper stuff entirely for now and release a 0.9.4 version of the crate without them, but that (I think) would be breaking the standard Rust versioning practices that people expect.
Maybe they'd be okay with it in this scenario, though. Or maybe not. It's hard to gauge. Any advice or input would be welcome!
from staticvec.
I do think it warrants a minor-version bump (0.10.0, I guess). That would also mean that any downstream crates would have to release a new version themselves with the updated dependency on staticvec
to be able to compile on the latest nightly.
But it sounds to me like an alright-enough option, since it pretty much allows both people on a "pinned" nightly and people who prefer to always stay with the latest one to both compile with this lib. And it also won't break any downstream crates depending on the older version and the combination stuff (I mean, they will break on latest nightly no-matter-what, but if you were to release a 0.9.4 they would also break on nightly versions that would otherwise work).
That's just my own $0.02, I definitely am not an expert on any of the things I talked about, so take with grain of salt etc... :P
from staticvec.
0.10.0 it is then I think. Will try to get it uploaded soon.
from staticvec.
Argh, now I have to find something different that looks cool to put in the readme also... this is the most annoying thing ever. No choice though...
from staticvec.
Hey, I'm sorry for not being explicit enough sooner:
this definitely solved everything for my use case, closing the issue since you've solved it.
Thanks again!
from staticvec.
No problem!
from staticvec.
Related Issues (20)
- There's not actually any practical reason for the `length` field of a StaticVec to be of type `usize` HOT 7
- staticsort depends on libstd HOT 3
- Add support for a StaticString based on StaticVec HOT 1
- Integrate StaticString with serde (and maybe diesel - partially) HOT 2
- Other collections on stack HOT 5
- Inconsistency in panicking string methods and truncating ones HOT 1
- Implement Copy for StaticString HOT 12
- `MaybeUninit::read` has been renamed into `assume_init_read` HOT 1
- Miri flag passing changed HOT 1
- Add a `StaticVecDeque` type HOT 2
- change requirement to rust stable HOT 1
- Doesn't compile on latest nightly HOT 1
- The `const_raw_ptr_to_usize_cast` feature has been removed HOT 17
- `const trait implementations may not use non-const default functions` HOT 3
- How unstable is this library? HOT 3
- Implement `core::fmt::Write` for `StaticVec` HOT 2
- add `const_intrinsic_copy` to rust features HOT 1
- Use Infallible for from_str HOT 1
- Compilation fails on latest nightly (e77366b57 2023-05-16) HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from staticvec.