Git Product home page Git Product logo

Comments (6)

kukulich avatar kukulich commented on May 30, 2024 1

@cleptric Set <property> to your ruleset.xml, similarly to https://github.com/slevomat/coding-standard/blob/2.0-dev/ruleset.xml#L35

from coding-standard.

kukulich avatar kukulich commented on May 30, 2024 1

@cleptric Try this:

- <rule ref="SlevomatCodingStandard.TypeHints.DeclareStrictTypes.IncorrectWhitespaceBetweenOpenTagAndDeclare">
+ <rule ref="SlevomatCodingStandard.TypeHints.DeclareStrictTypes">

from coding-standard.

kukulich avatar kukulich commented on May 30, 2024

@cleptric Can you try branch 2.0-dev? It contains newer version of this sniff.

from coding-standard.

cleptric avatar cleptric commented on May 30, 2024

@kukulich That fixes it, thx. Just another thing: How can I set the $newlinesCountBetweenOpenTagAndDeclare inside the DeclareStrictTypesSniff to 1? I want to use

<?php
declare(strict_types = 1);

from coding-standard.

cleptric avatar cleptric commented on May 30, 2024

@kukulich Inside the DeclareStrictTypesSniff, $newlinesCountBetweenOpenTagAndDeclare is still 0 when checked in line 91

<?xml version="1.0"?>
<ruleset name="Foo Type Hinting">
    <rule ref="vendor/slevomat/coding-standard/SlevomatCodingStandard/Sniffs/TypeHints/DeclareStrictTypesSniff.php" />
    <rule ref="SlevomatCodingStandard.TypeHints.DeclareStrictTypes.IncorrectWhitespaceBetweenOpenTagAndDeclare">
        <properties>
            <property name="newlinesCountBetweenOpenTagAndDeclare" value="1" />
        </properties>
    </rule>
    <rule ref="vendor/slevomat/coding-standard/SlevomatCodingStandard/Sniffs/TypeHints/ReturnTypeHintSpacingSniff.php"/>
    <rule ref="vendor/slevomat/coding-standard/SlevomatCodingStandard/Sniffs/TypeHints/TypeHintDeclarationSniff.php"/>
    <rule ref="vendor/slevomat/coding-standard/SlevomatCodingStandard/Sniffs/TypeHints/LongTypeHintsSniff.php"/>
</ruleset>

from coding-standard.

github-actions avatar github-actions commented on May 30, 2024

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

from coding-standard.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.