Support interop with other call adapters about eithernet HOT 6 CLOSED

The workaround for now would be to use the coroutines-rxjava interop library

interface PandaApi {
  @GET("/")
  suspend fun getPandas(): ApiResult<Pandas, Nothing>
}

// Use rxSingle
rxSingle { pandaApi.getPandas() }
  .subscribe { result -> ... }

from eithernet.

Oh interesting, so right now, if we wanted to use ApiResult<T, E> we can't use RxJava right away. Our best bet for async calls for a codebase that uses Rx would be to use coroutines adapter and then interop with Rxjava in order to work with existing Rx chains?

from eithernet.

Yup seems so. In principle it works but in testing it seems this is a java limitation

from eithernet.

I have an idea for this: we could use Retrofit's @Tag annotation to receive a custom ResultHint that in turn holds a ResultType instance. We can then look for this hint and use it as an override.

@GET("/")
fun anRxEndpoint(@Tag resultHint: ResultHint): Single<ApiResult<SuccessType, FailureType>>

It's annoyingly not type-safe though, but we could maybe we could encourage something like this

@GET("/")
fun anRxEndpoint(@Tag resultHint: ResultHint = ResultHint.create<SuccessType, FailureType>()): Single<ApiResult<SuccessType, FailureType>>

So then callers don't have to implement it themselves

from eithernet.

Another, possibly better alternative would be to see if we can read the full generic type from metadata annotations on the class. We'd have to step out of retrofit's standard API and incur the metadata parsing cost, but we could make it opt-in maybe?

from eithernet.

I'm going to close this as infeasible for now

from eithernet.