Git Product home page Git Product logo

Comments (4)

bensusman avatar bensusman commented on August 11, 2024

Apologies. It is associated by the Action field name, not the classname, correct?

I tried to clone the repo, and make the change myself and make a PR and what not, but I seem to be having some issues getting Eclipse to work nicely with Lombok.

from java-slack-sdk.

seratch avatar seratch commented on August 11, 2024

I don't understand what the points we need to change in the library code are. If you need to specify the value of attachments.actions.name, your own code can (to be exact, should) do that.

from java-slack-sdk.

bensusman avatar bensusman commented on August 11, 2024

The issue is not with the attachments.actions.name the issue is with attachments.actions.confirm.

For example an action should have the following json:

                {
                    "name": "game",
                    "text": "Thermonuclear War",
                    "style": "danger",
                    "type": "button",
                    "value": "war",
                    "confirm": {
                        "title": "Are you sure?",
                        "text": "Wouldn't you prefer a good game of chess?",
                        "ok_text": "Yes",
                        "dismiss_text": "No"
                    }
                }

but the Json output from jslack is:

                {
                    "name": "game",
                    "text": "Thermonuclear War",
                    "style": "danger",
                    "type": "button",
                    "value": "war",
                    "confirmation_message": {
                        "title": "Are you sure?",
                        "text": "Wouldn't you prefer a good game of chess?",
                        "ok_text": "Yes",
                        "dismiss_text": "No"
                    }
                }

Noting the difference between confirm and confirmation_message.

Does that clarify the the issue?

from java-slack-sdk.

seratch avatar seratch commented on August 11, 2024

Thanks, I understand. So this pull request originally had a bug. #12

It's pretty easy to fix this. Just renaming the ConfirmationMessage class to Confirm class. You don't need to setup your Eclipse for Lombok. Simply building with Gradle and ensuring the behavior by running tests would be enough. I'm looking forward to merging your pull request 😸

from java-slack-sdk.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.