Comments (3)
Removing the WeekViewStyle and adding the params to WeekView should work indeed. But I liked your idea of isolating the style (height/width/colors) from other more behaviour-ish parameters, so I'd be favorable to keeping the class, but just reducing the intersection with DayViewStyle params. It would also keep consistency with patterns in Flutter widgets (such as the 'decoration' param in Container). What do you think?
from flutterweekview.
I agree with you. The current system allows to separate the style part from the code part, but it may be a bit messy. Here's what we need to do :
- Refactor the
WeekViewStyle
class. - Review and merge #41.
- Test if everything is working as expected.
from flutterweekview.
What do you think?
I agree. I just thought about it briefly to be honest 😄
from flutterweekview.
Related Issues (20)
- Custom widget as Event HOT 1
- Press and drag causes UI issues on the web
- dayBarVisible
- Display Day of Week rather than date in WeekView HOT 1
- Only show title of event in WeekView cell HOT 1
- Click detection in an event HOT 4
- hourRowHeight not available
- Ability to scroll by one item in WeekView. HOT 1
- Setting inScrollableWidget to false throws error.
- DayViewController minZoom/maxZoom does not work
- ScrollController not attached to any scroll views HOT 3
- Full week on a single page HOT 1
- Add Ripple effect (using InkWell) to the events HOT 1
- How to get click event, if no event is set? HOT 1
- [FLUTTER 3] Warning: Operand of null-aware operation '?.' has type 'WidgetsBinding' which excludes null.
- Option to add an horizontal scrollbar
- Need current date of scrolled position HOT 3
- not responsive HOT 3
- Current time indicator is not on the exact current time
- how to set 12 hours format in day view ?
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from flutterweekview.