Comments (3)
wu-sheng
commented on August 22, 2024
We suspend the previous PR about manually cleaning current context.
I want to discuss this officially about how we treat this case?
Manually close seems misleading.
Does .net want newTracing API(or similar)? Or any suggestion?
Notice, we don't have this in any other agents AFAIK.
from skyapm-dotnet.
inversionhourglass
commented on August 22, 2024
I see java has CallableWrapper that also is a hardcode way. If you mean just don't hardcode directly use the tracing context, then I can implement it in a way similar to CallableWrapper. But the two methods in the PR are still needed, just not used in user code.
我看java也有 CallableWrapper 这种硬编码的方式， 如果你的意思是在用户代码中硬编码使用tracing context不合适，那我或许能以类似CallableWrapper的方式来实现。不过之前PR中的两个方法还是需要的，只是它们不直接在用户代码中使用。
from skyapm-dotnet.
wu-sheng
commented on August 22, 2024
@liuhaoyang Is the manually stopping trace context causing segment leak?
I don't know .net agent enough to make sure it is safe or not.
from skyapm-dotnet.
Related Issues (20)
- How to set tags HOT 1
- Should 'IExitSegmentContextAccessor' be used here?
- IEntrySegmentContextAccessor.Context is null HOT 1
- 请问怎么将SkyAPM-dotnet添加到wpf客户端或者Console客户端，形成一条从客户端到后台api的链路跟踪。 HOT 1
- May I ask if the log folder can be named after the month and year HOT 3
- 集成MagicOnion做Grpc链路追踪 HOT 1
- SkyAPM.Diagnostics.CAP System.MissingMethodException: Method not found sometimes HOT 2
- this is no service name display in Virtual Database HOT 3
- Does SkyAPM support Console Application?
- skywalking前端页面查询不到 HOT 5
- SKYWALKING__SERVICENAME 是否直接支持组名? 或者组名的环境变量是? HOT 1
- SkyApm.Transport.Grpc.V8.ServiceRegister : Report service instance properties fail. HOT 2
- How to support multiple environments. HOT 1
- CAP trace broken when using latest skyapm-dotnet code HOT 6
- How to modify the endpoint name of skywalking HOT 1
- SkyAPM.Agent.AspNetCore Version 2.1.0 cannot monitor the data of the IIS program HOT 2
- SkyApm.Transport.Grpc.LogReporter : Report log fail.
- 使用2.2 版本前端总是空的，2.1版本正常
- `AddSkyAPM` Break Change HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from skyapm-dotnet.