routeMap key is handler name, if different url paths route to same handler, only the last one is available to trace, consider using Method+Path as the key? about go2sky HOT 7 CLOSED

if we have a handler like:
func doSomething( c *gin.Context ) {...}

then register 2 handler:

eg = gin.New()
eg.Use( Middleware(eg, tracer) )
eg.POST( "/api/v1/m1", doSomething )
eg.POST( "/api/v1/m2", doSomething )

according to the code in go2sky gin plugin:
mm[r.Handler] = routeInfo{ operationName: fmt.Sprintf("/%s%s", r.Method, r.Path), }

the mm will be:

mm['doSomething'] = "/POST/api/v1/m1"         // will be overwrited by m2
mm['doSomething'] = "/POST/api/v1/m2"

all the request from "/POST/api/v1/m1" will be recognized as "/POST/api/v1/m2", as it's overwrited.

hope this helps.

from go2sky.

Hi @Logic0
Glad to receive your feedback. I don't quite understand what you said. Could you give me an example :)

from go2sky.

Thank you. It does happen. Let me see how to solve it.

from go2sky.

Hi @Logic0, If use http.Request.Method + http.Request.URL.Path as the operation name, so /user/:name will generate multiple operation name, I will keep the current solution until there is a better solution.

from go2sky.

We did a discussion, this should be plugin FAQ.

from go2sky.

@Logic0 As you have known the logic behind this, I recommend using a method wrapper to make this conflict gone. I have talked with @arugal, my suggestion would like to add a FAQ document with an example.

from go2sky.

Hi @Logic0 https://github.com/SkyAPM/go2sky-plugins/tree/master/gin/v3 We provide a new version, welcome to use.

from go2sky.