gin.Middleware initializes routeMap by gin.Context about go2sky HOT 6 CLOSED

Which library has a bug? go2sky or 3rd party?

from go2sky.

Which library has a bug? go2sky or 3rd party?

go2sky/plugins/gin/gin.go

from go2sky.

Could you try to submit a pull request to fix it?

from go2sky.

Hi @xuzq3 can you provide your code, I can't reproduce this bug :)

from go2sky.

go2sky/plugins/gin/gin.go

m.routeMapOnce.Do(func() {
	routes := engine.Routes()
	rm := make(map[string]map[string]routeInfo)
	for _, r := range routes {
		mm := rm[r.Method]
		if mm == nil {
			mm = make(map[string]routeInfo)
			rm[r.Method] = mm
		}
		mm[r.Handler] = routeInfo{
			operationName: c.Request.Host + c.Request.URL.Path,same
		}
		m.routeMap = rm
	}
})

Because of sync.Once, routeMap is initialized by gin.Context of the first request. And it will never change. When the url of the next request is different, operationName is wrong.

from go2sky.

haha @xuzq3 are you interested in fixing it :)

from go2sky.