Comments (4)
Could you point out the codes about this concern?
from go2sky.
Could you point out the codes about this concern?
Thanks for your reply. I mean in function call chain CreateEntrySpan->CreateLocalSpan->newSegmentSpan->newSegmentRoot. In func newSegmentRoot :
go func() {
total := -1
defer close(ch)
defer close(s.doneCh)
for {
select {
case span := <-s.notify:
s.segment = append(s.segment, span)
case n := <-s.doneCh:
total = int(n)
}
if total == len(s.segment) {
break
}
}
s.tracer.reporter.Send(append(s.segment, s))
}()
I'm worried about performance. I want a collector to be able to collect segments and send in batches after interval time or reach max count limit, rather than send each message immediately.
from go2sky.
I'm worried about performance.
If this reports as a grpc stream, it is safe. SkyWalking javaagent doesn't need any collector, it could work in 5k-10k tps with 10% CPU only. Your concern should base on experiences, and code optimization. In most cases, the collector wouldn't help.
from go2sky.
I'm worried about performance.
If this reports as a grpc stream, it is safe. SkyWalking javaagent doesn't need any collector, it could work in 5k-10k tps with 10% CPU only. Your concern should base on experiences, and code optimization. In most cases, the collector wouldn't help.
Thansk for your reply.
from go2sky.
Related Issues (20)
- close gRPCReporter error HOT 2
- go get error HOT 5
- Tracing event source and sink in knative eventing HOT 6
- How to send log to the log page? HOT 1
- Grpc Reporter's logger cannot use custom logger.
- To create a exit span with one statement, not two statement HOT 3
- It has small probability will be panic HOT 5
- [Broken] CROSS_PROCESS HOT 1
- Can go2sky support output to kafka/pulsar HOT 4
- go2sky.SetGlobalTracer is undefined in v1.3.0 HOT 1
- fetch dynamic configuration error rpc error: code = PermissionDenied desc = HOT 6
- send keep alive signal error rpc error HOT 3
- unexpected EOF HOT 2
- panic on google.golang.org/protobuf/encoding/protowire.AppendString
- Unexcepted parentSpanID when parent span is ended HOT 1
- fetch dynamic configuration error rpc error: code = Unimplemented desc = Method not found: skywalking.v3.ConfigurationDiscoveryService/fetchConfigurations HOT 6
- gRPCReporter can use nanosecond instead of millisecond HOT 1
- Make sampling decision with span tags. HOT 5
- reach max send buffer
- memory leak
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from go2sky.