Git Product home page Git Product logo

Comments (20)

skwp avatar skwp commented on July 18, 2024

That's a valid concern, but let's hold off on this for a sec until I integrate the other changes? I do like the ability to see plugins by author because it helps with correlating it to stuff happening on github (i.e. if i'm watching kien/ctrlp I can see when he made a change on github and consider updating). On the other hand this can be provided by a command that wraps a git submodule list.

from dotfiles.

kylewest avatar kylewest commented on July 18, 2024

That's fine, I created it as an issue instead of just doing it because (a) it's not incredibly important and (b) I figured there was some reason behind it.

BTW, here's a script that matches your description, a bit of a monster, but it works.

git submodule foreach git remote -v | grep -E 'origin.*\(fetch\)' | cut -d / -f 4,5 | sed 's/ (fetch)//' | sort

Output:

AndrewRadev/splitjoin.vim
Lokaltog/vim-easymotion
Raimondi/delimitMate
Shougo/neocomplcache.git
aaronjensen/vim-sass-status
austintaylor/vim-indentobject
bootleq/vim-textobj-rubysymbol
chrismetcalf/vim-yankring.git
claco/jasmine.vim
drewolson/ruby_focused_unit_test_vim
dterei/VimBookmarking
ecomba/vim-ruby-refactoring
garbas/vim-showmarks
godlygeek/csapprox.git
godlygeek/tabular
int3/vim-extradite
jistr/vim-nerdtree-tabs.git
jpalardy/vim-slime
kana/vim-textobj-datetime
kana/vim-textobj-entire
kana/vim-textobj-function
kana/vim-textobj-user
kchmck/vim-coffee-script
kien/ctrlp.vim
kien/tabman.vim
kogakure/vim-sparkup.git
majutsushi/tagbar.git
mattn/gist-vim
mattn/zencoding-vim
mikefarmer/snipmate.vim.git
mileszs/ack.vim
nathanaelkane/vim-indent-guides
nelstrom/vim-markdown-preview
nelstrom/vim-textobj-rubyblock
rson/vim-conque.git
scrooloose/nerdtree.git
scrooloose/snipmate-snippets.git
scrooloose/syntastic.git
sjbach/lusty.git
sjl/gundo.vim
skwp/greplace.vim
skwp/vim-colors-solarized
skwp/vim-git-grep-rails-partial
skwp/vim-html-escape
skwp/vim-indexed-search
skwp/vim-rspec
skwp/vim-ruby-conque
tjennings/git-grep-vim
tomtom/tcomment_vim.git
tpope/vim-endwise.git
tpope/vim-fugitive
tpope/vim-git
tpope/vim-haml
tpope/vim-pathogen
tpope/vim-rails.git
tpope/vim-repeat.git
tpope/vim-surround.git
tpope/vim-unimpaired
vim-ruby/vim-ruby.git
vim-scripts/AnsiEsc.vim.git
vim-scripts/AutoTag.git
vim-scripts/IndexedSearch
vim-scripts/Vim-R-plugin
vim-scripts/ZoomWin.git
vim-scripts/argtextobj.vim
vim-scripts/lastpos.vim
vim-scripts/matchit.zip.git
vim-scripts/sudo.vim
vim-scripts/taglist.vim.git
wavded/vim-stylus

from dotfiles.

maletor avatar maletor commented on July 18, 2024

Yes please rename. Author information is available from git via git remote -v

from dotfiles.

skwp avatar skwp commented on July 18, 2024

I wonder how badly this will screw over everyone who's cloned/forked it already though..?

from dotfiles.

maletor avatar maletor commented on July 18, 2024

Git is pretty smart. It's able to figure out when you rename stuff.

from dotfiles.

maletor avatar maletor commented on July 18, 2024

CJ has some good additions that should be inspected.

from dotfiles.

maletor avatar maletor commented on July 18, 2024

Especially the colors.

from dotfiles.

kylewest avatar kylewest commented on July 18, 2024

@skyp I have some other changes I need to wrap up and get back to you (editing zsh settings). Maybe it's time to create the yadr repo and make some of these breaking changes.

Kyle

from dotfiles.

skwp avatar skwp commented on July 18, 2024

@kylewest can we avoid breaking changes and still get the majority of improvements? what kind of breakage is anticipated?

from dotfiles.

kylewest avatar kylewest commented on July 18, 2024

That depends how tightly you define breaking. The changes don't necessarily break things, they just change them in the interest of making things easier for the new guys (and me when installing on multiple computers). For instance:

  • YADR currently depends on your fork of oh-my-zsh but most of us (guessing) have installed the original. So, I changed zshrc which changes the default theme.
  • YADR uses RVM and has the RVM plugin installed. I use rbenv. So, I changed zshrc to look for ~/.rvm or ~/.rbenv and load rvm or rbenv as appropriate.
  • I added a custom directory to store changes to zsh (like adding your own aliases).

Check out the compare view for all the details.

Wanted

  • I'd like to tame the symlinks all over the place that are used for backwards compatibility.
  • I'd like to rename the submodules to make it easier to find stuff.
  • Figure out a way to add/remove vim plugins without needing to create a fork.

Discussion

We allow .vimrc(before|after) from the home directory, but zsh overrides go in the custom directory. We should pick or the other and stick with it.

I'll have some extra time next week. If you want to hammer out the decisions I can get to the implementation.

from dotfiles.

kylewest avatar kylewest commented on July 18, 2024

One last thing. My ultimate intention is to get people using yadr without having to create a fork to do stuff like this:

In other words, allow users enough control to customize to their liking (ideally storing those customizations in a separate git repo) without having to maintain a fork of the project.

Kyle

from dotfiles.

skwp avatar skwp commented on July 18, 2024

Hm, so I like some of the stuff you're talking about like oh-my-zsh specifically. However, I am not sure I agree with the whole not forking thing. If we start to allow yadr to be ultra customizable, we are just going to re-implement Janus. Technically all of yadr could be done on top of Janus. The whole point of this project was to have an opinionated set of dotfiles. Janus by design is not opinionated - it offers a platform for customizing your vim setup. Yadr however, dictates a set of plugins and keybindings and visuals. The idea is people can and should fork it if they want to. Janus had this problem of crazy forking and tried to solve it by engineering (or overengineering, in my opinion) a system that tries to please everyone. This system is difficult to support, complex, and prone to errors. I don't want to make this a huge project with lots of flexibility, I want it to be an Apple-style ************, and if you want to deviate from the norm, then you should "jailbreak" it by forking. Otherwise, you get something nice that works out of the box that you don't need to eff with.

Some minor customizations are ok, even good..like having a vimrc before/after. However making a system that's flexible for plugin installation is just a reimplementation of janus, so I don't see value in that. Do you see where I'm coming from?

from dotfiles.

skwp avatar skwp commented on July 18, 2024

I guess where I'm coming from is that every single dotfile project on github has been forked to hell. There's no reason to try to prevent human nature with engineering, instead just embrace it :)

from dotfiles.

skwp avatar skwp commented on July 18, 2024

(p.s. I like most/all of what i'm seeing in the zsh compare view link you sent. can you make that into a pull request?)

from dotfiles.

kylewest avatar kylewest commented on July 18, 2024

No, completely get it. I wasn't thinking about people who want a completely different set of plugins/mappings, but instead the guy that wants (1) solarized light instead of dark, wants to (2) disable sparkup, and to (3) add vimroom. I think we took care of #1 with vimrc before/after and we may have handled 2/3 also but we need to document how to do it. I know pathogen is powerful but I haven't taken the time to figure this part out. Seems like it could be as easy as loading all plugins in /custom/vim/bundles along with those it currently loads.


RE: my branch. I will. I have been planning on it but life got in the way. I need to clean it up a bit, test, and write some docs. I'll try to get that done in the next couple days.

from dotfiles.

taybin avatar taybin commented on July 18, 2024

I think a bunch of this could be worked around by renaming .secrets to .zshrc.local. The .secrets name implies I only want to store secret stuff like the GITHUB_TOKEN.

.zshrc.local shows that is where I should put path stuff, exports, the zsh theme, stuff like that. This seems a little off topic for this issue though. Maybe start a new one to discuss it in?

from dotfiles.

skwp avatar skwp commented on July 18, 2024

@taybin i opened an issue to rename secrets to zshrc.local, I'll get to it soonish

from dotfiles.

kylewest avatar kylewest commented on July 18, 2024

@skwp let's do this as part of the general installer cleanup?

from dotfiles.

skwp avatar skwp commented on July 18, 2024

ok sounds good

from dotfiles.

skwp avatar skwp commented on July 18, 2024

I'm going to close this for now, feel free to reopen if it needs to be worked on, but since it's like 7 months old, it's just cluttering up the view of what actually needs to be done :)

from dotfiles.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.