Git Product home page Git Product logo

Comments (4)

skryukov avatar skryukov commented on May 27, 2024 1

Do you mean inherit_gem? Could you provide a minimal reproduction for that bug, I tried this config and it worked fine for me (i.e. Foo.find_by_id(1) was always ignored):

require:
  - rubocop-gradual
  - rubocop-rails

inherit_gem:
  rubocop-rails:
    - config/default.yml

Rails/DynamicFindBy:
  Enabled: false

from rubocop-gradual.

pboling avatar pboling commented on May 27, 2024 1

Closing in favor of the idea that this is mostly within core RuboCop.

Note that the number of violations found by RuboCop changes when I run with and without NO_GRADUAL=1, but I can't address that reliably until the core bug is fixed.

This issue shouldn't hold up a release here.

from rubocop-gradual.

pboling avatar pboling commented on May 27, 2024

I have also seen now that when I run with NO_GRADUAL=1 bundle exec rubocop and:

  • have commented the inherit_gem directives, to skip the gems' rules:
    • the rules directly below, in the local .rubocop-yml file, apply
  • have uncommented the inherit_gem directives, to load the gems' rules:
    • the rules directly below, in the local .rubocop-yml file, are ignored
    • even though they should have the highest precedence

At minimum, some of the bug is in RuboCop core.

from rubocop-gradual.

pboling avatar pboling commented on May 27, 2024

Yes, corrected. I think the issue is likely entirely inside RuboCop, and I think it is caused by an entire department being disabled in the gem's config, and then no matter what you do you can't enable a specific rule from that department. I've reported it here: rubocop/rubocop#12315

from rubocop-gradual.

Related Issues (10)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.