[Bug] azure-configuration branch is missing about deploy-to-azure HOT 10 CLOSED

See the discussion board for more on this: https://github.com/orgs/skills/discussions/14

It's not that the branch is missing. There is a missing yaml file (spinup-destroy.yml) and a missing commit of that file to the azure-configuration branch. This means that the head and base refs point to the same commit when trying to create the PR. That will throw the error you got because you can't create a PR with no commits in it. There must be a difference in history between HEAD and base refs.

I think everyone is waiting for the Skills team to take another look at this lab, because there are a number of issues with it that need to be fixed (See dicussion thread about it.)

from deploy-to-azure.

I'll need to defer to @skills/skills-content-reviewers for questions on course content.

from deploy-to-azure.

Thanks for the information, is there any timeline for the bug fix? Thanks！

from deploy-to-azure.

@heiskr / @emilyistoofunky any thoughts about this ?

from deploy-to-azure.

We're open to pull requests. I believe a contractor ported this course from a previous Learning Lab version:

• https://github.com/githubtraining/continuous-delivery-azure
• https://github.com/githubtraining/continuous-delivery-azure-template

from deploy-to-azure.

I've opened a PR for this. It's still WIP and I'd appreciate some input from the Skills team. Step 2 requires a spinup-destroy.yml workflow to be added. Originally, this was added via a step and bash script in the .github/workflows/2-setup-azure-environment.yml workflow. To automate the adding of the spinup-destroy.yml workflow file, a PAT with workflow scope will need to be used.

Would it be better to get the learner to create the scoped PAT and add it to their course repo, or would it be better to get the learner to add the spinup-destroy.yml workflow themselves (along with branch and PR)? (Or option 3 which I haven't thought of?)

from deploy-to-azure.

We're now in December. Any chance this lab will be corrected anytime soon?

from deploy-to-azure.

Any updates?

from deploy-to-azure.

This exercise should be removed from the learning path at https://learn.microsoft.com/en-us/training/modules/github-actions-cd/3-create-workflow-deploy-azure
until it is fixed.

from deploy-to-azure.

Thank you for opening this issue. I'm closing this issue out per #20 (comment)

The GitHub Skills folks don't control or influence the content on Microsoft Learn, just fyi.

from deploy-to-azure.