Comments (10)
See the discussion board for more on this: https://github.com/orgs/skills/discussions/14
It's not that the branch is missing. There is a missing yaml file (spinup-destroy.yml
) and a missing commit of that file to the azure-configuration
branch. This means that the head and base refs point to the same commit when trying to create the PR. That will throw the error you got because you can't create a PR with no commits in it. There must be a difference in history between HEAD and base refs.
I think everyone is waiting for the Skills team to take another look at this lab, because there are a number of issues with it that need to be fixed (See dicussion thread about it.)
from deploy-to-azure.
I'll need to defer to @skills/skills-content-reviewers for questions on course content.
from deploy-to-azure.
Thanks for the information, is there any timeline for the bug fix? Thanks!
from deploy-to-azure.
@heiskr / @emilyistoofunky any thoughts about this ?
from deploy-to-azure.
We're open to pull requests. I believe a contractor ported this course from a previous Learning Lab version:
- https://github.com/githubtraining/continuous-delivery-azure
- https://github.com/githubtraining/continuous-delivery-azure-template
from deploy-to-azure.
I've opened a PR for this. It's still WIP and I'd appreciate some input from the Skills team. Step 2 requires a spinup-destroy.yml
workflow to be added. Originally, this was added via a step and bash script in the .github/workflows/2-setup-azure-environment.yml
workflow. To automate the adding of the spinup-destroy.yml
workflow file, a PAT with workflow
scope will need to be used.
Would it be better to get the learner to create the scoped PAT and add it to their course repo, or would it be better to get the learner to add the spinup-destroy.yml
workflow themselves (along with branch and PR)? (Or option 3 which I haven't thought of?)
from deploy-to-azure.
We're now in December. Any chance this lab will be corrected anytime soon?
from deploy-to-azure.
Any updates?
from deploy-to-azure.
This exercise should be removed from the learning path at https://learn.microsoft.com/en-us/training/modules/github-actions-cd/3-create-workflow-deploy-azure
until it is fixed.
from deploy-to-azure.
Thank you for opening this issue. I'm closing this issue out per #20 (comment)
The GitHub Skills folks don't control or influence the content on Microsoft Learn, just fyi.
from deploy-to-azure.
Related Issues (20)
- Option '--sdk-auth' has been deprecated and will be removed in a future release. HOT 1
- [Bug] dead link in call for feedback link at the end of the course HOT 1
- `spinup-destroy.yml` file and `azure-configuration` branch missing HOT 4
- [Bug] Step missing for Activity 1: Add triggers to production deployment workflow after steps 6 HOT 2
- Update course name to "Deploy to Azure"
- Pull-Main.sh missing [Bug] HOT 5
- Node build fails with latest version [Bug] HOT 2
- [Bug] 2-setup-azure-environment.yml Error HOT 3
- [Bug]Test HOT 1
- Update discussions link
- [Bug] Node version error, cannot complete step 4. HOT 3
- [Bug] Inaccurate headings and readme saying Deploy to a production environment based on labels HOT 1
- [Bug] Inaccurate comments in `4-deploy-to-staging-environment.yml` make search for terms confusing HOT 1
- [Bug] Error while executing the spinup-destroy.yml workflow HOT 1
- [Bug] On repo clone, cannot run ./.github/script/initialize-repository.sh: Permission denied HOT 1
- [Bug] Warnings of deprecation and vulnerabilities on step 5 - Deploy
- [Bug] spin up label isn't created automatically
- [Bug] AZURE_CREDENTIALS are in instructions but never created HOT 1
- open email account[Feature]
- [Bug] Distinguish difference between personal (classic) access tokens and fine-grained access tokens HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from deploy-to-azure.