Git Product home page Git Product logo

Comments (6)

AdrianGonz97 avatar AdrianGonz97 commented on June 3, 2024 2

@endigo9740 @Mahmoud-zino Caching is automatically done on Github's API end via cache headers. No need to do anything special on our end 😄

from skeleton.

endigo9740 avatar endigo9740 commented on June 3, 2024 1

It's grid based, show it should just be a matter of trying different combinations. I believe we have ~100 unique contributors, so if we can manage to fit most/all at once that would be great. Vitest has a lot for example:

https://vitest.dev/

Just be mindful of performance since this is on the homepage!

The hard part shouldn't be the layout, it should be figuring out how to fetch this from GitHub. Right now I'm using a third party service that provides a restful call for this. Retrieving directly from GitHub would be ideal, but I believe the only option they provide is GraphQL based.

Maybe start there, look into retrieving the data. Then if you feel you need help with the layout, let me know. Happy to jump into a PR and edit directly as well

from skeleton.

Mahmoud-zino avatar Mahmoud-zino commented on June 3, 2024

correction: only 30 are showed at the moment.

@endigo9740 If you have a layout for the avatars in mind, I would be happy to implement it 👍

from skeleton.

Mahmoud-zino avatar Mahmoud-zino commented on June 3, 2024

@endigo9740 I just checked the docs, we are retrieving the contributors list from the official GitHub API:
https://api.github.com/repos/skeletonlabs/skeleton/contributors I wouldn't change this, I will just add per_page=100 queryparam to get 100 results at once (It is still very fast, you won't notice the difference between 30 and 100).
I think the performance hit will be in the avatar trying to load everything at once, so we can add lazy loading to that.

from skeleton.

endigo9740 avatar endigo9740 commented on June 3, 2024

@Mahmoud-zino good to know, that sounds much easier then! I do recall @AdrianGonz97 building some sort of caching into this to help with performance, but I don't recall the specifics. You might double check with him if you get a moment.

from skeleton.

endigo9740 avatar endigo9740 commented on June 3, 2024

Welp, that's easy!

from skeleton.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.