Comments (3)
This is now ready to test on branch feat/theme-css
. Use the GitHub CLI to pull and test via:
gh pr checkout 137
This does the following:
- Moves
/src/themes
->/lib/styles/themes
- Divides our global CSS into smaller "stylesheet add-ons" in
/lib/styles/{core|typography|forms}.css
- Updated all documentation pages relevant to this change.
- Declutters the Styles guide a bit, now "Presets" and the "Theme Generator" are folded under a radio group
NOTE: all instructions are specific to the selected framework.
If you would like to test these instructions in a new Skeleton project, you'll need to create a local package to install. To do this, follow the instructions below:
- Pull down the branch and run the following in the root
npm run package
- Move into the package directory via
cd package
- Create a local tarball (like a zip) via:
npm pack
- Cut and paste the
.tgz
file into the root of your new Skeleton project - Finally run
npm install {tarballFile}.tgz
to install locally - Follow all instructions in the documentation provided.
from skeleton.
After thinking about it, the way we import the stylesheet add-ons may need to change slightly. The concept is right, but order of imports is wrong. Should be:
- @tailwind directives
- (these add-ons)
- Any custom global styles or overrides
The reason for this is the add-ons need to come -after- the directives, or they will not work as expected. They must also come before the custom styles otherwise you cannot override them (ex: override the default form background color)
Will need to move the import from the layout file to the global stylesheet itself.
This should not interfere with general testing, just note this gotcha if you're writing your own styles.
from skeleton.
I've pushed a change that resolves this. It seems Vite doesn't allow you to handle imports from node_modules
within your global stylesheets. So instead I've implemented an additional import that handles the @tailwind directives. The preferred order of import from top to bottom is:
tailwind.css
core.css
typography.css
forms.css -> only if you use the TW forms plugin
(global stylesheet here)
Here's how that's presented:
from skeleton.
Related Issues (20)
- Add accessibility attributes to Autocomplete HOT 1
- [Skeleton v2] - Light scrollbar is displayed instead of dark one on Opera browser HOT 4
- Autocomplete page: Add blurb about importing popup in popup section
- AppRailTile and AppRailAnchor default styling
- progressbar.css in build HOT 1
- v3 dep bump
- Possibilty to disable focus of Ratings component inner buttons HOT 2
- Move `data-theme` from `body` tag to `html` tag
- App Shell prevents Safari bottom address bar from collapsing on iOS HOT 2
- card-header and card-footer need radius overrides when bg-color-X set HOT 3
- Storybook (integration) HOT 3
- ModalStore.trigger from within response - puts in strange state HOT 4
- W3C validator complains HOT 1
- [Maybe DUP] Modal stack, without closing prev modal (modal on modal on modal...) HOT 1
- v3 Doc Site - bump depdencies
- A small typo in the props of the App Rail - background and border HOT 2
- Be able to get a reference to <input> inside InputChip, and a way to forward actions to button HOT 2
- Provide less cartoonish styles HOT 2
- Embedding the changelog of skeleton packages into the doc website. HOT 2
- BUG: framework picker is not working post doc updates
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from skeleton.