Git Product home page Git Product logo

Comments (3)

skaslev avatar skaslev commented on July 20, 2024

Hi Hugh,

Thank you for the code and for catching the missing PFNGLGETBOOLEANV function.

gl3w is meant to use the glcorearb.h file that gets downloaded besides the gl3w.h header and is working fine on Windows as is if you have gl3w/include in your include path.

I'm not convinced that inlining all needed #defines and typedefs is worth it since it might be a source of more flakiness (such as the PFNGLGETBOOLEANV case you caught). Also, imo it's better to limit gl3w just to extension loading and let glcorearb.h define the OpenGL API as it's designed for.

The tabs are there because the generated gl3w's C code follows the Linux kernel coding style. I might reconsider this since it's not the first time that this is being brought up and most Python developers (and IDEs) frown upon tabs in Python source.

Lastly, would you consider sending pull requests in the future instead of uploading complete files since it's easier to track what exactly got changed.

from gl3w.

skaslev avatar skaslev commented on July 20, 2024

On second look, the current version of gl3w does correctly expose glGetBooleanv.

from gl3w.

laranzu avatar laranzu commented on July 20, 2024

I'm not convinced that inlining all the #defines and typedefs is always worth it either, just sometimes. For my project I wanted a single header, so modified gl3w_gen. Once I'd done so, offering the code back seemed the right thing to do. You could either merge the extra code into gl3w_gen and add a CLI option to select between the two, or leave it as a separate program, or whatever else you decide.

Yes glGetBooleanenv works. I think my approach of selecting the PF--PROC typedefs out with a regex causes the problem. I'd have done better to generate them from the GL command names instead.

from gl3w.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.