Comments (6)
I think I understand what you want. This is not possible in the code as is. But can be added.
It is not easy to add a 'salt' element to a PatiententID. I think the easiest alternative is to add a 'salt' value type here
https://github.com/sjoerdk/pimsclient/blob/master/pimsclient/client.py#L290
And then have a SaltIdentifier(TypedIdentifier) like here https://github.com/sjoerdk/pimsclient/blob/master/pimsclient/client.py#L386 and a SaltPseudonym
You can then have the salt as a separate entry and use for example the value of the pseudo patient ID as the key for this so you can look it up.
If you make a PR I can look at it Wednesday
from pimsclient.
Submitted a PR #93. I noticed that now per patient I add two entries: PatientID and Salt. Using sequential patient IDs, each new patient skips a number. So e.g. first patient I add has pseudonym 000001
, then the next has 000003
. I suppose this is something internal to PIMS?
from pimsclient.
Yes the skipping of numbers is a bug/feature of the underlying PIMS implementation made by IM.
If you work with larger batches the skipping gets larger.
This has been identified as a problem, but is currently hard/ costly to fix for them. I think this should be fixed, but there should be sufficient pressure on IM to do so. Currently I will leave it as is.
from pimsclient.
@brambozz could you close this issue when working with salt works for you?
from pimsclient.
OK, it's not a big problem, but just looks a bit weird :)
It's already working for me, so I will close. Could you push a new version to PyPI?
from pimsclient.
Yes I think it looks very weird and should be changed. Good thing is that in the worst case, when PIMS does not get updated at all, the pimsclient code can be configured to use a different backend..
I will bump the software version. That will make CI push to pypi
from pimsclient.
Related Issues (9)
- Add AccessionNumber datatype
- Allow manual setting of pseudonym/identifier pairs
- Add set_keys() ignore_errors flag HOT 1
- Add debug print for all requests HOT 1
- PIMS API endpoint Files/Deidentify silently skips consistency errors HOT 2
- No way to check whether identity has a pseudonym without creating pseudonym HOT 2
- Server response code exception text is unbounded HOT 1
- Add msal auto-re-login
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from pimsclient.