Comments (4)
The library already has classes/structs for Rectangle
and Ellipse
do we want to expand these by letting them implement IShape
and push the logic down there? or should we create new classes RectangularPolygon
and ElipticalPolygon
which take an Rectangle
and Ellipse
as constructor args?
If we go for the second option the we would need/want to provide override extension methods that can take the struct versions and internally convert them to the polygon versions.
My vote would be for option 2 creating RectangularPolygon
and ElipticalPolygon
but just after some opinions.
from imagesharp.
My vote would also be for option 2 because we might add extra stuff that is only for drawing.
from imagesharp.
Agreed. Option 2 would be best. I'd like to keep the original rectangle as is and use it simply for expressing an area of interest. I might even drop the original Ellipse as I'm not sure it's being used anywhere.
from imagesharp.
Shape are now handled by https://github.com/SixLabors/Shapes thus new primitive shapes should be requested over there.
Additionally, Ellipse/Circle, Regular 'X' sided shapes do now exist.
from imagesharp.
Related Issues (20)
- Error SixLabors.ImageSharp.ImageFormatException: 'Unexpected chunk followed VP8X header' HOT 3
- File (detected as bmp) fails to open, consumes a lot of memory HOT 4
- regression on latest.. 3 vs 2 with GIF HOT 6
- APNG Decoder incorrectly handles frame offsets and dispose previous with blend over HOT 3
- Hard crash (Internal CLR error) with corrupt PNG image HOT 3
- File conversion from jpg to webp changes colors of the image HOT 1
- Malicious hand-crafted PNG can be used to trigger DOS attack HOT 14
- I have encountered a bug with heigh and width of image HOT 4
- Missing Separable Blending Modes? HOT 2
- AccessViolationException when loading corrupt GIF
- Loading image with DecoderOptions { MaxFrames = 1 } loads multiple frames for attached png file
- Rotation of AffineTransform seems to offset the image by 1 pixel HOT 29
- After the jpeg image is loaded, there is a problem with the image color HOT 1
- Issue for load image in table cell in ver. 3.1.4 HOT 1
- Payloads that caused a DOS attack (GIF / JPEG) HOT 5
- Webp encoding produces completely transparent images HOT 5
- PNG to WebP conversion: some files 10x larger than with `cwebp` HOT 3
- PngEncoder ignores FilterMethod HOT 2
- `Fatal error. Internal CLR error` when working with image created by pointer-based overload of `Image.WrapMemory<TPixel>` HOT 1
- Issues Loading JFIF/JPG images from S3 HOT 6
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from imagesharp.