Add additional Shapes for drawing. about imagesharp HOT 4 CLOSED

The library already has classes/structs for Rectangle and Ellipse do we want to expand these by letting them implement IShape and push the logic down there? or should we create new classes RectangularPolygon and ElipticalPolygon which take an Rectangle and Ellipse as constructor args?

If we go for the second option the we would need/want to provide override extension methods that can take the struct versions and internally convert them to the polygon versions.

My vote would be for option 2 creating RectangularPolygon and ElipticalPolygon but just after some opinions.

from imagesharp.

My vote would also be for option 2 because we might add extra stuff that is only for drawing.

from imagesharp.

Agreed. Option 2 would be best. I'd like to keep the original rectangle as is and use it simply for expressing an area of interest. I might even drop the original Ellipse as I'm not sure it's being used anywhere.

from imagesharp.

Shape are now handled by https://github.com/SixLabors/Shapes thus new primitive shapes should be requested over there.

Additionally, Ellipse/Circle, Regular 'X' sided shapes do now exist.

from imagesharp.