doesn't work with lighthouse devtoolslog.json? about chrome-har HOT 14 OPEN

+1.

from chrome-har.

Sorry I don't know what Lighthouse produces. I've seen there have been multiple issues where people have had problem with Puppeteer where the trace logs aren't the same as If you use standalone Chrome, maybe it's something like that?

from chrome-har.

I provided a link to a gist containing what lighthouse produces - it looks a lot like the stuff in the test/ directory but not exactly apparently?
How specifically are you generating those test files via the chrome remote debugger protocol? From Network events like https://chromedevtools.github.io/devtools-protocol/tot/Network#event-responseReceived ?
thanks!!

from chrome-har.

I guess it still could be that the events are out of order and we don't catch that and in Chrome using Browsertime they are not. I will happily merge a PR if anyone can fix it :)

Best
Peter

from chrome-har.

so do you think it's 'just' an ordering problem? do you look at the output from lighthouse in the gist? thanks!!

from chrome-har.

I don't know but that's my guess :)

from chrome-har.

ok ya I moved the 'Page.frameStartedLoading' event to the top the lighthouse-generated JSON file and all worked :)
In the lighthouse file there are Network.requestWillBeSent and Network.responseReceived events in the file with the matching frameId BEFORE the Page.frameStartedLoading event with the same frameId.
Not sure if the fix is to just error out with an explanation when this happens (easy) or to attempt to buffer those events and 'replay' them once we see the Page.frameStartedLoading event (hard), or to pre-process/re-write the json file on the fly when this condition is detected.
OR just punt :)

from chrome-har.

I did a fix a couple of days ago to catch requestWillBeSent that happens before navigation https://github.com/sitespeedio/chrome-har/pull/34/files but then I guess also the responses are received in your trace before the frame started loading? Those responses could be mapped to the "unmapped" requests then.

from chrome-har.

Yes correct in my trace I see requests and a response BEFORE the Page.frameStartedLoading event with the matching frameId.

So when I use a lighthouse trace and run it thru the tests (with my 'fix' to move stuff to the beginning of the 'messages' array I get this error:

entry._requestTime
=> 47731.117649


dunno if you need the whole 'entry' object that gets dumped after this...
So my 'fix' does not work? thanks!!

from chrome-har.

Having the same issue running chrome-har with puppeteer.

    TypeError: Cannot read property 'content' of undefined
    at harFromMessages (/Users/me/Desktop/har-backup/node_modules/chrome-har/index.js:316:28)
    at /Users/me/Desktop/har-bckup/index.js:48:17
    at <anonymous>

    "chrome-har": "^0.7.0",
    "puppeteer": "^1.11.0"

node: v8.14.0
Chromium: r609904

Thanks for any suggestions for getting this working.

from chrome-har.

Yeah, as I said before I think the problem is the order. I haven't had time to look at it yet, working on other things first.

from chrome-har.

I did a fix in 13a21ea for this, one thing missing is handling of redirects, I'll look at that later today.

from chrome-har.

I've pushed 0.7.1 with fixes that collect requests/responses that happens before navigation. One known bug is that it doesn't handle redirects. Please let me know if the new version works for you both!

from chrome-har.

from chrome-har.