Comments (4)
Hi @jpmzometa, thanks for catching this bug. I think I messed up how strings/bytes are handled in a specific spot.
I've created a possible fix on a different branch: https://github.com/sirMackk/py3tftp/tree/issue_3_fix, would it be possible for you to run the code from that branch and see if your issue is fixed? If you're not comfortable with the python toolchain, I can help out a bit and guide you.
from py3tftp.
Hi @jpmzometa, can you confirm if the patch fixes the problem?
from py3tftp.
Hi. I tested it and it seems to work, but not as I expected. I guess the documentation is not clear on the meaning of --conn-timeout:
Timeout before the server gives up on a transfer and closes the connection.
As it now is, this timer seems to be reset every time a packet arrives at the server. I thought it was a sort of "global" timer, that starts as soon as a transfer is requested, and if the full transfer is not finished before the timer expires, the connection should be closed. Anyways, the current implementation of --conn-timeout is fine as it is, just the documentation is not very clear.
from py3tftp.
Great, many thanks @jpmzometa! I'll expand the readme to include that bit of information and I'll create a new release for pypi this weekend.
from py3tftp.
Related Issues (8)
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from py3tftp.