--ack-timeout and --conn-timeout do not seem to work about py3tftp HOT 4 CLOSED

Hi @jpmzometa, thanks for catching this bug. I think I messed up how strings/bytes are handled in a specific spot.

I've created a possible fix on a different branch: https://github.com/sirMackk/py3tftp/tree/issue_3_fix, would it be possible for you to run the code from that branch and see if your issue is fixed? If you're not comfortable with the python toolchain, I can help out a bit and guide you.

from py3tftp.

Hi @jpmzometa, can you confirm if the patch fixes the problem?

from py3tftp.

Hi. I tested it and it seems to work, but not as I expected. I guess the documentation is not clear on the meaning of --conn-timeout:

Timeout before the server gives up on a transfer and closes the connection.

As it now is, this timer seems to be reset every time a packet arrives at the server. I thought it was a sort of "global" timer, that starts as soon as a transfer is requested, and if the full transfer is not finished before the timer expires, the connection should be closed. Anyways, the current implementation of --conn-timeout is fine as it is, just the documentation is not very clear.

from py3tftp.

Great, many thanks @jpmzometa! I'll expand the readme to include that bit of information and I'll create a new release for pypi this weekend.

from py3tftp.