Bug on some static variables about phpcs-variable-analysis HOT 4 CLOSED

Hi @sirbrillig,

The code that you leave does not give any error, apparently the problem occurs when the static variable is defined within a control structure. I could be able to generate the problem with the following code.

<?php

class ClassWithStaticVarFunction
{
    public function method_with_static_assigned_local_var()
    {
        $var1 = 1;

        if ($var1 === 1) {
            static $new_var = null;

            if ($new_var === null) {
                echo 'it is null';
            }
        }
    }
}

Here an evidence.

Hope this help you to fix this.

Regards!

from phpcs-variable-analysis.

Clearly you've found a bug! 😅 Thank you. I'm having trouble reproducing it, though. Could you provide more of a context of your example? Are you in a function in a class? If I do this, it does not seem to report an error:

class ClassWithStaticVarFunction {
    function method_with_static_assigned_local_var() {
        static $new_var = null;
        if ($new_var === null) {
            echo 'it is null';
        }
    }
}

from phpcs-variable-analysis.

Thank you! That was the hint I needed.

from phpcs-variable-analysis.

Thanks, it works perfect now!

from phpcs-variable-analysis.