Unexpected failure in foreach statement about phpcs-variable-analysis HOT 4 CLOSED

PHP doesn't offer any alternatives

I mean, there's foreach ( array_keys( $recipe_json ) as $key ), but I see your point. For large arrays that's another time through.

Ah, good point. Even so, I think this is one of those border areas (i.e. there's a reasonable explanation for an unused variable).

from phpcs-variable-analysis.

It should be the same, yes. If you set allowUnusedForeachVariables to true, then it will not be reported. But this does continue that discussion, specifically

we can consider if we want that option to be on by default

What do you think? It seems like there's an obvious benefit, but the reason I haven't enabled it by default already is that I haven't taken the time to examine the possible downsides. It definitely hides unused variables and I wonder if that's something that could be problematic for some code.

from phpcs-variable-analysis.

It'd make sense to me to enable allowUnusedForeachVariables by default because PHP doesn't offer any alternatives.

Similarly, I also had to enable allowUnusedCaughtExceptions.

from phpcs-variable-analysis.

PHP doesn't offer any alternatives

I mean, there's foreach ( array_keys( $recipe_json ) as $key ), but I see your point. For large arrays that's another time through.

Let me work up a PR and we'll see what that looks like.

Similarly, I also had to enable allowUnusedCaughtExceptions.

That's a good point and not one I've seen mentioned a lot, but it could probably help more people to have that on be default as well.

from phpcs-variable-analysis.