Git Product home page Git Product logo

Comments (4)

rfuchs avatar rfuchs commented on July 22, 2024

Hey,

The ABNF notation of 1*9DIGIT means between 1 and 9 digits, where a digit is defined as 0-9 (RFC4234). This means that a tag of "0" should be valid. The only restriction the RFC places on the tag is that leading zeroes must not be used. Now I don't know if that disqualifies "0" as a valid tag, I'd say it's ambiguous at best.

As such, I think a good client should accept "0" as a valid tag, but as for offering, it's probably safer to start at 1, even though there seem to be other clients out there which also put a "0" tag.

from rtpengine.

edjames99 avatar edjames99 commented on July 22, 2024

Great, thanks for the quick clarification. I suppose if a client starts at 0 in an offer then it would probably accept 0 in the response but the client I'm using starts at 1 in an offer and doesn't seem to like offers with 0.

Could this default be changed ? Sorry, I'm not sure how of the process.

from rtpengine.

rfuchs avatar rfuchs commented on July 22, 2024

Yeah I'll change it, just making sure that there are no negative side effects to this.

You may still want to submit a bug report for your client though. AFAICT, zero is a valid tag and a client should always accept it, even if the client itself prefers to offer with a "1" tag.

from rtpengine.

edjames99 avatar edjames99 commented on July 22, 2024

Thanks for your help, that's great.

from rtpengine.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.