Comments (8)
Oops, that's no good. I can fix this. Don't know why I forgot this, but I think it's a simple matter of exposing the method, e.g. like sinon.mock.fail.
from sinon.
Hey, the function is now exposed as sinon.expectation.fail(message); It receives the failing message. Let me know if you need anything else.
from sinon.
Thanks for looking at this, but I'm afraid the change doesn't actually work. The mock module still takes a copy of expectation.fail, so replacing it has no effect.
A simple fix would be to replace
var err = sinon.expectation.fail
with
var err = function(msg) { sinon.expectation.fail(msg); }
At line 413
from sinon.
Hah, stupid. Sorry. Inlined the calls.
from sinon.
Is this scheduled for a release soon? I just horribly confused myself when installing via npm instead of github tarball and not getting this fix :)
from sinon.
Sorry. I'll get a relase out this week!
from sinon.
1.2.0 is out now!
from sinon.
excellent, thanks!
from sinon.
Related Issues (20)
- Bug mocking with SWC HOT 14
- 'TypeError: Attempted to wrap undefined property as function' while stubbing a module function HOT 4
- Improve error message given when a property is only exposed as a getter HOT 3
- Throw meaningful error message when trying to return non-objects from stub used as constructor HOT 1
- Improve error message for immutable descriptors to include link to article HOT 1
- Spies for property accessors are not automatically cleaned up
- Use sinon to mock node-mssql HOT 1
- No useRealTimers() or runAllTimers() ? HOT 1
- I can't find the CHANGELOG HOT 9
- Elaborate on "For the stubbing to work, the stubbed method cannot be destructured, neither in the module under test nor in the test." HOT 5
- Unable to install [email protected] HOT 6
- Remove unused/meaningless exports and modules from the codebase HOT 1
- Limit assertion log to a reasonable default HOT 1
- `returns` not override `callThrough` HOT 4
- `returns` clears fake's `callArgAt` HOT 5
- Discrepancy in stub construction methods HOT 4
- Feature Request: Add API support to stub a parent class constructor. HOT 4
- .rejects doesn't match documentation HOT 2
- SyntaxError: Unexpected token . -> assert(opts?.sinonXhrLib, "No XHR lib passed in"); HOT 1
- Documentation of callIds
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from sinon.