Git Product home page Git Product logo

Comments (8)

cjohansen avatar cjohansen commented on August 17, 2024

Oops, that's no good. I can fix this. Don't know why I forgot this, but I think it's a simple matter of exposing the method, e.g. like sinon.mock.fail.

from sinon.

cjohansen avatar cjohansen commented on August 17, 2024

Hey, the function is now exposed as sinon.expectation.fail(message); It receives the failing message. Let me know if you need anything else.

from sinon.

glenjamin avatar glenjamin commented on August 17, 2024

Thanks for looking at this, but I'm afraid the change doesn't actually work. The mock module still takes a copy of expectation.fail, so replacing it has no effect.

A simple fix would be to replace
var err = sinon.expectation.fail
with
var err = function(msg) { sinon.expectation.fail(msg); }

At line 413

from sinon.

cjohansen avatar cjohansen commented on August 17, 2024

Hah, stupid. Sorry. Inlined the calls.

from sinon.

glenjamin avatar glenjamin commented on August 17, 2024

Is this scheduled for a release soon? I just horribly confused myself when installing via npm instead of github tarball and not getting this fix :)

from sinon.

cjohansen avatar cjohansen commented on August 17, 2024

Sorry. I'll get a relase out this week!

from sinon.

cjohansen avatar cjohansen commented on August 17, 2024

1.2.0 is out now!

from sinon.

glenjamin avatar glenjamin commented on August 17, 2024

excellent, thanks!

from sinon.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.