Git Product home page Git Product logo

Comments (3)

bkfarnsworth avatar bkfarnsworth commented on May 27, 2024 3

@joeldenning I'm using single-spa-react, so I don't ever call parcel.unmount on my side manually. It gets unmounted because the parent react component gets unmounted, and then tries to unmount again in the same tick of the event loop when the route changes. I've put a bandaid in for now where I get a reference to the parcel and I poll the status until it is in the MOUNTED state. But its not a scalable fix - we will share many components cross-MFE, and we will run into this issue again and again. It seems like parcel should be able to handle if a call to unmount comes in while it is in the UNMOUNTING state

from single-spa.

joeldenning avatar joeldenning commented on May 27, 2024

I don't think a change to single-spa is necessary here, since parcel.getStatus() can be called to check whether the parcel is ready to unmount:

if (parcel.getStatus() === "MOUNTED") {
  parcel.unmount();
}

I'm open to discussing changing the related internal single-spa logic, but don't see why it's necessary

from single-spa.

MilanKovacic avatar MilanKovacic commented on May 27, 2024

Hi @bkfarnsworth, sorry for the late reply. We were/are working on internal improvements. I will take a look at the issue.

from single-spa.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.