isCanceled is not set to true when shouldReject is set to false and promise is rejected in onCancel about p-cancelable HOT 3 CLOSED

I think onResolve and onReject function needs to be updated like below to prevent state change after canceling.

const onReject = error => {
  if (this.#state !== promiseState.canceled || !onCancel.shouldReject) {
    reject(error);

    if (this.#state !== promiseState.canceled) {
      this.#state = promiseState.rejected;
    }
  }
};

Then, the example code result will be like the below (expected result)

canceled
Second main catch error: Error: canceled
Don't worry it was canceled

I just made a PR fixing it in this way.

from p-cancelable.

Ok, I see that it is because there is a reject(new Error('canceled')); line in the onCancel handler which overwrites the state of the promise. But actually, I find it a bit confusing that the promise reports it was not canceled when it actually was.

Maybe the promise should additionally rely on a new internal variable isCanceled rather than only on the state which looks like is overwritable?

from p-cancelable.

This looks like a bug. A canceled state should be immutable.

@jopemachine Thoughts?

from p-cancelable.