Comments (8)
Something like this:
diff --git a/index.js b/index.js
index 44f453a..b4bafb6 100644
--- a/index.js
+++ b/index.js
@@ -41,7 +32,7 @@ function requestAsEventEmitter(opts) {
res.resume();
if (++redirectCount > 10) {
- ee.emit('error', new GotError('Redirected 10 times. Aborting.'), undefined, res);
+ ee.emit('error', new MaxRedirectsError(statusCode, {url: url}), undefined, res);
return;
}
@@ -70,7 +61,7 @@ function requestAsEventEmitter(opts) {
ee.emit('response', res);
}).once('error', function (err) {
- ee.emit('error', new GotError('Request to ' + url + ' failed', err));
+ ee.emit('error', new RequestError(err.message, {url: url, method: opts.method}));
});
if (opts.timeout) {
@@ -101,22 +92,21 @@ function asCallback(opts, cb) {
ee.on('response', function (res) {
readAllStream(res, opts.encoding, function (err, data) {
if (err) {
- cb(new GotError('Reading ' + url + ' response failed', err), null, res);
+ cb(new ReadError(err.message, {url: url}), null, res);
return;
}
var statusCode = res.statusCode;
if (statusCode < 200 || statusCode > 299) {
- err = new GotError(opts.method + ' ' + url + ' response code is ' + statusCode + ' (' + http.STATUS_CODES[statusCode] + ')', err);
- err.code = statusCode;
+ err = new HTTPError(statusCode, {url: url, method: opts.method});
}
if (opts.json && statusCode !== 204) {
try {
data = JSON.parse(data);
} catch (e) {
- err = new GotError('Parsing ' + url + ' response failed', new GotError(e.message, err));
+ err = new ParseError(err.message, {url: url});
}
}
from got.
👍
from got.
Yup, I like it too. +1 for more clarity.
from got.
Done in 1fe1e9a - please review 😃
from got.
There is one question, that's bothers me: should we store statusCode as code
property? It was discussed in #9, but in other places people tend to use statusCode
((https://github.com/trentm/node-bunyan#log-record-fields, https://github.com/jshttp/http-errors).
from got.
I prefer statusCode
as it's a clearer intent.
from got.
@floatdrop What happened to floatdrop@58bfb20 in the 4.0.0 PR? Did you back out of it?
from got.
@sindresorhus yup, I will send a PR with this soon.
from got.
Related Issues (20)
- `Response<string>` returned rather than a json response HOT 2
- Is v13 still maintained/supported? HOT 1
- Hangs on revalidated response from cache
- Infinite redirection with special characters in the redirected URL HOT 1
- Support `servername` https option
- How to get traffic usage per request? HOT 1
- Is it possible to skip/disable normalization of a request body? HOT 1
- afterResponse fired 3 times on error HOT 3
- Getting the IP address for failed requests due to timeout
- Post request to API returns response code 500 (Internal Server Error) whereas CURL returns 200 status code HOT 2
- Timeouts are longer than expected HOT 1
- NPM Says: Types are not integrated HOT 1
- FormData getLength can error out when some file input is unknown stream.
- POSTs whose bodys are instances of createReadStream hang with latest node HOT 5
- Apply `applyDestroyPatch` for v11.x
- Stream report downloadProgress when redirects HOT 1
- Is TypeScript support outdated? HOT 1
- Good News for CJS
- afterResponse hook is not called after a retryWithMergedOptions() HOT 2
- HTTP2 with proxy doesn't work? (http2-wrapper)
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from got.