Downloads from within webview about electron-dl HOT 5 CLOSED

Actually, if the BrowserWindow's webcontents and webview's webcontents are on the same partition, they'll end up sharing the same session instance and, since the 'will-download' listener is attached on session, electron-dl should work for the webview as well.

I guess a more general approach would be to leverage the event session-created instead of browser-window-created (or the web-contents-created like I suggested above):

app.on('session-created', (session) => {
  session.on('will-download', (e, item, contents) => {
    let hostWebContents = contents;
    if (contents.getType() === 'webview') {
      const hostWebContents = contents.hostWebContents;
    }
    const hostWin = BrowserWindow.fromWebContents(hostWebContents);
    ...
  });
});

from electron-dl.

It could find all the webviews, iterate through them, and subscribe, but not something I need, so would have to be a pull request.

from electron-dl.

I think the problem is related to lack of "app" in the webview, see attached screenshot when trying to download an image inside a webview (thanks for https://github.com/sindresorhus/electron-context-menu BTW)

from electron-dl.

I guess leveraging the (undocumented) eventweb-contents-created instead of browser-window-created here will roughly do the trick.
One can then get the "host window" using BrowserWindow.fromWebContents(contents.hostWebContents) where contents is the webview's WebContents.

Could probably introduce an option to opt-in or opt-out the handling of webviews, and leverage the undocumented contents.getType() like this:

app.on('web-contents-created', (event, contents) => {
  if (contents.getType() === 'webview') {
    const hostWin = BrowserWindow.fromWebContents(contents.hostWebContents);
  }
 });

from electron-dl.

@alexstrat Thanks, you suggestion works.

from electron-dl.