Inspect Element with debug on about electron-context-menu HOT 8 CLOSED

Maybe this can just be used as a dependency of electron-context-menu? You wouldn't want two context menus that could conflict. https://github.com/parro-it/debug-menu

from electron-context-menu.

How about instead depend on https://github.com/sindresorhus/electron-is-dev and show the Inspect Element menu when it's in dev? No need for the user to use electron-debug. We could then just recommend this module in the electron-debug readme if they want Inspect Element.

from electron-context-menu.

How about instead depend on https://github.com/sindresorhus/electron-is-dev and show the Inspect Element menu when it's in dev? No need for the user to use electron-debug.

Yes I agree, that's a more direct solution.

from electron-context-menu.

Alright. PR welcome :)

from electron-context-menu.

Maybe this can just be used as a dependency of electron-context-menu? You wouldn't want two context menus that could conflict. https://github.com/parro-it/debug-menu

I noticed these kind of conflicts within different context menu, so sometimes ago I wrote electron-contextmenu-middleware to solve the issue. It allow you to compose different context menus with a middleware style pattern.

https://github.com/parro-it/electron-input-menu is another module that use this pattern.

Maybe you could give it a shot, it could be useful to integrate the idea in this repo?

from electron-context-menu.

@parro-it thanks, I actually found your repos when I implemented my PR and learned some stuff from your code! 😄

I didn't implement your middleware package b/c it would have required refactoring other parts (right?) and didn't know if @sindresorhus would have an opinion.

from electron-context-menu.

I deliberately wanted something opinionated and simple for my apps. All that's required is one line. Users can't change the core functionality here, but they can add stuff if they need to. Fits my needs better.

from electron-context-menu.

@parro-it thanks, I actually found your repos when I implemented my PR and learned some stuff from your code! 😄

That's great to hear! I'm honestly feeling bad because I noticed this module when Sindre create it. I thought to get in touch but than completely forgot about it...

Anyway, If it's not too late I still think that the idea of using middleware pattern to integrate multiple context menu providers could deserve further discussion... I would be happy to help you and eventually integrate my context-menu related modules with electron-context-menu (or the other way around).

Let's wait for @sindresorhus opinion about...

from electron-context-menu.