Comments (8)
Maybe this can just be used as a dependency of electron-context-menu
? You wouldn't want two context menus that could conflict. https://github.com/parro-it/debug-menu
from electron-context-menu.
How about instead depend on https://github.com/sindresorhus/electron-is-dev and show the Inspect Element
menu when it's in dev? No need for the user to use electron-debug
. We could then just recommend this module in the electron-debug
readme if they want Inspect Element
.
from electron-context-menu.
How about instead depend on https://github.com/sindresorhus/electron-is-dev and show the Inspect Element menu when it's in dev? No need for the user to use electron-debug.
Yes I agree, that's a more direct solution.
from electron-context-menu.
Alright. PR welcome :)
from electron-context-menu.
Maybe this can just be used as a dependency of electron-context-menu? You wouldn't want two context menus that could conflict. https://github.com/parro-it/debug-menu
I noticed these kind of conflicts within different context menu, so sometimes ago I wrote electron-contextmenu-middleware to solve the issue. It allow you to compose different context menus with a middleware style pattern.
https://github.com/parro-it/electron-input-menu is another module that use this pattern.
Maybe you could give it a shot, it could be useful to integrate the idea in this repo?
from electron-context-menu.
@parro-it thanks, I actually found your repos when I implemented my PR and learned some stuff from your code! ๐
I didn't implement your middleware package b/c it would have required refactoring other parts (right?) and didn't know if @sindresorhus would have an opinion.
from electron-context-menu.
I deliberately wanted something opinionated and simple for my apps. All that's required is one line. Users can't change the core functionality here, but they can add stuff if they need to. Fits my needs better.
from electron-context-menu.
@parro-it thanks, I actually found your repos when I implemented my PR and learned some stuff from your code! ๐
That's great to hear! I'm honestly feeling bad because I noticed this module when Sindre create it. I thought to get in touch but than completely forgot about it...
Anyway, If it's not too late I still think that the idea of using middleware pattern to integrate multiple context menu providers could deserve further discussion... I would be happy to help you and eventually integrate my context-menu related modules with electron-context-menu
(or the other way around).
Let's wait for @sindresorhus opinion about...
from electron-context-menu.
Related Issues (20)
- Not working in Electron 14.0.0 HOT 1
- Electron 15: Module '"electron"' has no exported member 'WebviewTag' HOT 3
- Interaction with menubar HOT 1
- Enable accelerators for edit options HOT 1
- Ability to hide "Copy Link" and "Save Link As" for `file://` protocol HOT 2
- Incorrect Typescript types for defaultActions
- Default action `saveLinkAs` does not exist in Typescript type definitions
- Add other search engines HOT 4
- Picture in picture HOT 1
- [HELP] get link when right click HOT 2
- Allows to translate "No Guesses Found" when no suggestion are available
- The default options like 'cut' 'copy' 'paste', etc. don't show accelerators next to them HOT 5
- How to add all โPasteโ and โPaste as plain textโ ?
- Can I paste an image? HOT 1
- Shortcuts not working HOT 1
- Not working with Electron version >=27
- icon for menu items HOT 1
- Failed to locate module "cli-truncate" HOT 2
- Add `showDictionarySuggestions` option
- Memory leak issue when multiple windows are used.
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. ๐๐๐
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google โค๏ธ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from electron-context-menu.