Git Product home page Git Product logo

Comments (19)

sindresorhus avatar sindresorhus commented on May 22, 2024

I know that's the OS X way, but doesn't make a lot of sense when the app is a single-window app. Why do you need this?

from caprine.

jedireza avatar jedireza commented on May 22, 2024

I've been closing the app instead of just hiding the window. I guess it's muscle memory. The Gitter and Slack apps, although single windows also work this way.

from caprine.

sindresorhus avatar sindresorhus commented on May 22, 2024

If you intend to hide it, you should just hide it and not close it then: Cmd H

Caprine works like any other single-window apps on OS X: Notes, Reminder, Photos, Contacts, App Store, Photo Booth, FaceTime, Calculator, Dictionary, etc. All of those close the app if you close the window.

from caprine.

timche avatar timche commented on May 22, 2024

+1

In my opinion, Caprine should stay active. It's a chatting application and needs the option to stay active in the background. I'm closing my app windows with cmd + w in any other app like Slack or Goofy/ChitChat.

If there's no chance to built this feature in, a fork will be necessary sooner or later, since Caprine is far better than Goofy and I don't want to switch back.

from caprine.

sindresorhus avatar sindresorhus commented on May 22, 2024

@timche Other apps doing it wrong is not a good argument. Cmd+H is the standard way of hiding a window. It's kinda amazing that you would rather maintain a fork than learn how to do it correctly...

from caprine.

timche avatar timche commented on May 22, 2024

Can you show me where this rule is written down that this is a wrong approach?

It's just how the majority of apps are handling cmd + w and they are not closing the app at all ... I don't need apps like Notes, Contacts, App Store running frequently in the background so it's okay they close at cmd + w, but when I'm using a chat app, I expect it's not quitting the whole app with cmd + w. I'm not the only one with this expectation.

from caprine.

sindresorhus avatar sindresorhus commented on May 22, 2024

Can you show me where this rule is written down that this is a wrong approach?

What the built-in apps do is the rule in my view. If you can find anything written backing your argument I would be happy to reconsider.

But again, why not just always use Cmd+H and get consistent behaviour instead of Cmd+W which behaves sporadically.

from caprine.

timche avatar timche commented on May 22, 2024

If you can find anything written backing your argument I would be happy to reconsider.

I can't, it's just my personal experience with other apps I'm using daily.

But again, why not just always use Cmd+H and get consistent behaviour instead of Cmd+W which behaves sporadically.

Because I'm already get used to cmd + w, which behaves actually consistent except in Caprine.

Please don't get me wrong, I'm really happy with Caprine and you did some nice work, because Goofy has a really poor performance. This cmd +w thing is the only point which would make Caprine a perfect Messenger app for OSX in my eyes.

from caprine.

sindresorhus avatar sindresorhus commented on May 22, 2024

I need to think about this. If this were to be accepted it would pretty much just be hiding the window on close, so that you would still get notifications while the window is "closed" (hidden). Would be really helpful to see something written in favor of this, though. That would make the decision easier.

from caprine.

OakNinja avatar OakNinja commented on May 22, 2024

The "minimize on quit" behavior is, to me, a school book example of bad UX. There is a workaround; Use the designated minimize/hide functionality. Please do not modify the expected behavior.

from caprine.

sindresorhus avatar sindresorhus commented on May 22, 2024

@OakNinja Nobody has mentioned "minimize". It's unclear if you're arguing for or against what's being requested in this issue.

from caprine.

OakNinja avatar OakNinja commented on May 22, 2024

@sindresorhus sorry if I was being unclear, I talked about behavior in a general fashion. That's why I said minimize/hide. I like when close means close, hide means hide, etc. I don't like when close means hide, hide means close, or any variant of such.

from caprine.

timche avatar timche commented on May 22, 2024

You are getting it wrong.

As I said above, close doesn't mean to close the whole app. There is a difference between close and quit on OS X. On most apps, cmd+w (close) is just closing the window (not hiding/minimizing) and not quitting the app. There are exceptions that are quitting the whole app with cmd+w, but these are rare (i.e. OS X built in apps like System Preferences or Calendar).

from caprine.

OakNinja avatar OakNinja commented on May 22, 2024

@timche that is true for multi-window applications. But even on OSX, single window applications usually close on close.

from caprine.

sindresorhus avatar sindresorhus commented on May 22, 2024

@timche I've thought long and hard about this and decided to accept it if someone does a good pull request. I've noticed that a similar app, Messages.app, is kept open on window close even though it's a single-window app. The implementation should just do this though:

If this were to be accepted it would pretty much just be hiding the window on close, so that you would still get notifications while the window is "closed" (hidden).

This is because the browser window needs to run for notifications to come through.

from caprine.

timche avatar timche commented on May 22, 2024

This is a good solution. Thanks @sindresorhus.

from caprine.

sindresorhus avatar sindresorhus commented on May 22, 2024

Fixed in 0.4.0: https://github.com/sindresorhus/caprine/releases/tag/0.4.0

from caprine.

seriema avatar seriema commented on May 22, 2024

@sindresorhus how do I close the app completely on Windows? I close the window, as that's the only option I have, but the processes stick around until I kill them with the Task Manager.

from caprine.

sindresorhus avatar sindresorhus commented on May 22, 2024

@seriema Yeah, I didn't consider Windows when doing this. I use OS X. Seems like #36 will fix this, right?

from caprine.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.