Git Product home page Git Product logo

Comments (3)

olleolleolle avatar olleolleolle commented on May 27, 2024 1

Now, having re-read the description and example a few times, I also feel it's probably a mistake, a bug, introduced by confusing this API with something like https://api.rubyonrails.org/classes/ActiveModel/AttributeAssignment.html.

from sinatra.

olleolleolle avatar olleolleolle commented on May 27, 2024

So, I support removing.

from sinatra.

mwpastore avatar mwpastore commented on May 27, 2024

Wow, what a mess. Sorry y'all. Looks like I was aiming to make it work like ActiveSupport::HashWithIndifferentAccess (i.e. initialize an indifferent hash with normalized entries) but maybe erroneously thought that Hash#initialize expects the same kind of argument (when it actually expects a default value object)? So as discussed in #1948 calling super is the wrong thing to do here; I should have either implemented initializing logic a la ActiveSupport::HashWithIndifferentAccess#initialize or simply omitted the initializer entirely. Since we already removed the misleading documentation for the former behavior I support removing the initalizer as well.

Bad design, bad execution, bad documentation... again, my apologies.

from sinatra.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.