Git Product home page Git Product logo

Comments (63)

tibbi avatar tibbi commented on September 3, 2024

Hey, can you shoot me a mail at [email protected] , so I can send you a test version please? It works fine on my device :p

from simple-file-manager.

morfikov avatar morfikov commented on September 3, 2024

I also can confirm that after granting root privileges there's nothing in the root folder.
file

from simple-file-manager.

morfikov avatar morfikov commented on September 3, 2024

@tibbi any idea on this bug?

from simple-file-manager.

tibbi avatar tibbi commented on September 3, 2024

the guy reported this issue right after releasing it, his problem was that "awk" package was missing and I couldnt use the required command. I guess that will be your issue too. Root folders could be listed without that too, but its currently not a high enough priority to rewrite it.

from simple-file-manager.

morfikov avatar morfikov commented on September 3, 2024

That's weird because I have busybox installed and:

# adb shell
X1_Max:/ $ su
X1_Max:/ # echo $PATH
/su/bin:/sbin:/vendor/bin:/system/sbin:/system/bin:/su/xbin:/system/xbin
X1_Max:/ # which awk
/su/xbin/awk

Should I install it in some other place?

from simple-file-manager.

tibbi avatar tibbi commented on September 3, 2024

Aha, can you then try this version Im attaching? You will probably see some messages appear as you select the root folder while having Root Access enabled in app settings, whats written on them? Uninstall the current one and allow installing apps from unknown sources at the security settings of your device. Remove the ".zip" appendix from the attachment, its just because github doesnt allow uploading .apk files. Thanks
app-release.apk.zip

from simple-file-manager.

morfikov avatar morfikov commented on September 3, 2024

I did what you asked for, but it looks like there's no messages when I select the root folder. I have root access enabled and removed the previous version of the app.

from simple-file-manager.

tibbi avatar tibbi commented on September 3, 2024

how about this one? Also what if you disable Root Access, do you see any files there?
app-release.apk.zip

from simple-file-manager.

morfikov avatar morfikov commented on September 3, 2024

When I start the app, now I can see this message (with root):

check: simple mobile tools

Still no root content. What is the "simple mobile tools"?

from simple-file-manager.

tibbi avatar tibbi commented on September 3, 2024

its just a simple echo to see if the console works at all, and I see the output. How about now? What do you see?
app-release.apk.zip

from simple-file-manager.

morfikov avatar morfikov commented on September 3, 2024

Now it says:

path:

from simple-file-manager.

tibbi avatar tibbi commented on September 3, 2024

Alright, this should do something more then. It apparently somehow got to trimming the slash of the root folder, which is not happening on my device.
app-release.apk.zip

from simple-file-manager.

morfikov avatar morfikov commented on September 3, 2024

Now it's

path:/

from simple-file-manager.

tibbi avatar tibbi commented on September 3, 2024

and nothing else after it? No files or other messages appear?

from simple-file-manager.

morfikov avatar morfikov commented on September 3, 2024

No other message, no files.

from simple-file-manager.

tibbi avatar tibbi commented on September 3, 2024

ok, here is hopefully a last one
app-release.apk.zip

from simple-file-manager.

morfikov avatar morfikov commented on September 3, 2024

It's still the same message and no files.

from simple-file-manager.

tibbi avatar tibbi commented on September 3, 2024

weird... Ill try a simple "ls", do you see anything?
app-release.apk.zip

from simple-file-manager.

morfikov avatar morfikov commented on September 3, 2024

Wow, now it worked :D

screenshot_20171001-235302

from simple-file-manager.

tibbi avatar tibbi commented on September 3, 2024

can you send me some screenshot? Maybe the values are in a different order than on my device, so it parses it wrong.

from simple-file-manager.

morfikov avatar morfikov commented on September 3, 2024

I think it's not what it supposed to be. But at least it displays something :)

from simple-file-manager.

tibbi avatar tibbi commented on September 3, 2024

tomorrow I will compare it with the output on my device and figure out whats wrong. Thanks for now

from simple-file-manager.

morfikov avatar morfikov commented on September 3, 2024

Ok. :)

from simple-file-manager.

tibbi avatar tibbi commented on September 3, 2024

So, how about this one? Ive changed something. You shouldnt see any popups, it should just work in theory.
app-release.apk.zip

from simple-file-manager.

morfikov avatar morfikov commented on September 3, 2024

I've just tested it, and still no files.

from simple-file-manager.

tibbi avatar tibbi commented on September 3, 2024

oh cmon, how about this one? The first message will be "index ", is the number 4 or 5? What about the next messages, can you give me a screenshot of one again? Thanks
app-release.apk.zip

from simple-file-manager.

morfikov avatar morfikov commented on September 3, 2024

Index 5
screenshot_20171002-213411screenshot_20171002-213706

from simple-file-manager.

tibbi avatar tibbi commented on September 3, 2024

How about this? It should print out a weird command.
app-release.apk.zip

from simple-file-manager.

morfikov avatar morfikov commented on September 3, 2024

screenshot_20171002-214657

from simple-file-manager.

tibbi avatar tibbi commented on September 3, 2024

You should see some "Output xxx" messages now, do you? Do you maybe see some "RETURN xxx" or "ERROR xxx"?
app-release.apk.zip

from simple-file-manager.

morfikov avatar morfikov commented on September 3, 2024

No messages this time.

from simple-file-manager.

tibbi avatar tibbi commented on September 3, 2024

wow, how about now?
app-release.apk.zip

from simple-file-manager.

morfikov avatar morfikov commented on September 3, 2024

Now it says:
Completed 0

from simple-file-manager.

tibbi avatar tibbi commented on September 3, 2024

ok Ill try removing parts of that command, hope it wont last much longer. Do some messages appear now?
app-release.apk.zip

from simple-file-manager.

morfikov avatar morfikov commented on September 3, 2024

No messages.

from simple-file-manager.

tibbi avatar tibbi commented on September 3, 2024

now?
app-release.apk.zip

from simple-file-manager.

morfikov avatar morfikov commented on September 3, 2024

Still nothing.

from simple-file-manager.

tibbi avatar tibbi commented on September 3, 2024

this?
app-release.apk.zip

from simple-file-manager.

morfikov avatar morfikov commented on September 3, 2024

Yes, now I have something.

from simple-file-manager.

tibbi avatar tibbi commented on September 3, 2024

the file/folder permissions? letters like d/r/w/x/- ?

from simple-file-manager.

morfikov avatar morfikov commented on September 3, 2024

Yes:

screenshot_20171002-231425

from simple-file-manager.

tibbi avatar tibbi commented on September 3, 2024

now?
app-release.apk.zip

from simple-file-manager.

morfikov avatar morfikov commented on September 3, 2024

No messages.

from simple-file-manager.

tibbi avatar tibbi commented on September 3, 2024

I dont know man, looks like there is something wrong with the system command inside awk. Its strange that it doesnt even give some error, I dont know how to fix it without having a broken device. Ill give up now as it apparently doesnt affect anyone else, but thanks a lot for the testing and feedback.

from simple-file-manager.

morfikov avatar morfikov commented on September 3, 2024

Maybe it's because of Android 7.0?

from simple-file-manager.

tibbi avatar tibbi commented on September 3, 2024

Im not sure. There just arent enough people using the file manager yet, especially with root access. I will have a rooted xiaomi where I want to install Android 7, I just have to wait 2 more days before they allow unlocking it...

from simple-file-manager.

morfikov avatar morfikov commented on September 3, 2024

Ok, so if you had something to test, just ask. :)

from simple-file-manager.

tibbi avatar tibbi commented on September 3, 2024

you could test Amaze File Manager at https://play.google.com/store/apps/details?id=com.amaze.filemanager , or its at f-droid too. Its an opensource file manager, it has root access hidden somewhere inside settings too. Ive checked their code already, but it looks weird. I might have to rewrite my way of handling root folders too so it wont use awk at all. The File manager just isnt a priority for now tho, there are more popular apps too.

from simple-file-manager.

morfikov avatar morfikov commented on September 3, 2024

I've just checked it, and its root feature works fine. BTW: it's a really nice app :)

from simple-file-manager.

tibbi avatar tibbi commented on September 3, 2024

ok thanks. Guess you can use it if you need root :D

from simple-file-manager.

tibbi avatar tibbi commented on September 3, 2024

Root handling will be rewritten in 3.2.0, check if is better. You still cannot really do any operations, just hopefully browse the items.

from simple-file-manager.

morfikov avatar morfikov commented on September 3, 2024

I just checked and I don't have good news. When I grant root permissions and select the "root" storage, the app thinks a few seconds and then crashes.

from simple-file-manager.

tibbi avatar tibbi commented on September 3, 2024

Ok, I see your crashdump, it shouldnt be anything difficult. Just to know for sure whats wrong, can you try this version? It shouldnt crash, can you send me the message that will appear? Thanks
file-manager-release.apk.zip

from simple-file-manager.

morfikov avatar morfikov commented on September 3, 2024

Here's the message:
https://i.imgur.com/ACY9Egx.png

from simple-file-manager.

tibbi avatar tibbi commented on September 3, 2024

alright cool, thanks. Can you try this, if it works? You wont see any error messages in case it goes wrong. Try browsing between folders etc.
file-manager-release.apk.zip

from simple-file-manager.

morfikov avatar morfikov commented on September 3, 2024

It looks like it's working now (at least I get the file list), but files have 0-byte size.
I got 1 crash while switching the dirs.
And also switching dirs takes a really long time, and sometimes the app hangs.

from simple-file-manager.

tibbi avatar tibbi commented on September 3, 2024

ok thats good enough, I will be improving it over time step by step :) I will update the playstore version in a couple days, i dont want to update it too frequently. Get version 3.2.1 from playstore whenever it gets available so you wont miss the updates. Thanks

from simple-file-manager.

tibbi avatar tibbi commented on September 3, 2024

Ive just released 3.2.1, it should fix that crash

from simple-file-manager.

morfikov avatar morfikov commented on September 3, 2024

I had that crash only once, and I wasn't able to reproduce the issue after that.

I just checked whether changing dirs works without a problem, and it does, but it's a little bit slow -- I wasn't able to enter a dir that has 100+ files in it, but there was no crash, so I think it's good. :D

from simple-file-manager.

tibbi avatar tibbi commented on September 3, 2024

alright. Ye it will be improving over time, step by step :) Root file handling is done in a whole different way than normal files so I basically have to implement everything from scratch.

from simple-file-manager.

pacien avatar pacien commented on September 3, 2024

Hello, I am encountering a different but probably related issue with v3.3.2 running on Android 5.1.1.
Please see the attached screenshot.

screenshot_2018-03-20-20-10-25

from simple-file-manager.

tibbi avatar tibbi commented on September 3, 2024

heh, ye Ill take a look at it someday, thanks

from simple-file-manager.

tibbi avatar tibbi commented on September 3, 2024

some rooting related things changed since then, open a new clean issue if some reproducible issues still happen

from simple-file-manager.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.