Events not cleared in node v0.10 about simplecrawler HOT 13 CLOSED

Awesome, thanks for providing a test case!

I'll investigate why this is happening tonight. :)

from simplecrawler.

I traced it to v0.9.12 being the first version to behave like this.

Running node v0.9.11
6 May 15:34:42 - Are test an instance of Crawler: false
6 May 15:34:42 - Are test an instance of Crawler: true
6 May 15:34:42 - Running: true
6 May 15:34:42 - Stopping crawler
6 May 15:34:42 - Running: false
6 May 15:34:42 - Listners:
[ [Function: datahandler] ]
6 May 15:34:42 - Removing listeners
6 May 15:34:42 - Listners:
[]
6 May 15:34:44 - http://deewr.gov.au/
6 May 15:34:46 - http://deewr.gov.au/rss/deewr-videos.xml

Running node v0.9.12
6 May 15:45:20 - Are test an instance of Crawler: false
6 May 15:45:21 - Are test an instance of Crawler: true
6 May 15:45:21 - Running: true
6 May 15:45:21 - Stopping crawler
6 May 15:45:21 - Running: false
6 May 15:45:21 - Listners:
[ [Function: datahandler] ]
6 May 15:45:21 - Removing listeners
6 May 15:45:21 - Listners:
[]
6 May 15:45:23 - http://deewr.gov.au/
6 May 15:45:23 - http://deewr.gov.au/
6 May 15:45:25 - http://deewr.gov.au/rss/deewr-videos.xml
6 May 15:45:25 - http://deewr.gov.au/rss/deewr-videos.xml

Seems like there is many changes to events: nodejs/node-v0.x-archive@v0.9.11-release...v0.9.12-release.

For example: nodejs/node-v0.x-archive@8ab346c

from simplecrawler.

After actually sitting down and looking at this, it really seems like a node problem, or perhaps something to do with how I'm attaching the crawler prototype to EventEmitter. I'm doing an investigation of the node/lib/events.js source now to see whether there's anything I can do (or whether the problem is just caused by me being an idiot, which is highly likely.)

Thanks again for the detailed test case! :)

from simplecrawler.

https://github.com/cgiffard/node-simplecrawler/blob/master/lib/crawler.js#L140

The "New way" of doing is util.inherits(Crawler, EventEmitter) if i remember correctly.
Not sure if it will help tho :)

I can give it a shot.

from simplecrawler.

Weird, I could have sworn I changed it to that ages ago. This one must have escaped my attention.

from simplecrawler.

OK, it works, and I don't know why. I'll push the change but do some more investigating! :) Thanks for your help.

from simplecrawler.

I've pushed 0.2.4 to npm. Can you verify whether the fix worked or not?

from simplecrawler.

I think you should add a EventEmitter.call(this); here: https://github.com/cgiffard/node-simplecrawler/blob/master/lib/crawler.js#L37

See: http://nodejs.org/docs/latest/api/util.html#util_util_inherits_constructor_superconstructor

from simplecrawler.

OK. (Although I must say it's rather annoying that I have to run the EventEmitter constructor too :P)

from simplecrawler.

Done! Can you check it? :)

(Pushed to git, but not npm... yet.)

from simplecrawler.

OK, it's on npm as 0.2.5.

from simplecrawler.

Seems fine now :)

Running node v0.10.5
7 May 15:39:31 - Are test an instance of Crawler: false
7 May 15:39:31 - Are test an instance of Crawler: true
7 May 15:39:31 - Running: true
7 May 15:39:31 - Stopping crawler
7 May 15:39:31 - Running: false
7 May 15:39:31 - Listners:
[ [Function: datahandler] ]
7 May 15:39:31 - Removing listeners
7 May 15:39:31 - Listners:
[]
7 May 15:39:33 - http://deewr.gov.au/
7 May 15:39:35 - http://deewr.gov.au/rss/deewr-videos.xml

from simplecrawler.

Cool. Thanks again! :)

from simplecrawler.