Font assets not included in PHP package about simple-icons-font HOT 5 CLOSED

Sorry I haven't understood what you was trying to said.

You're right, the distribution folder is not generated before we "upload" to Packagist. I'm not sure how can we upload these assets to Packagist as they just release the tag pushed to Github, just supposing that we need to include the distribution folder in the tag which is... strange IMHO? Not sure. This problem can be checked downloading manually the latest version through this URL.

Unfortunately I don't have time to work on this nor motivation as I haven't used PHP in my whole life. This integration was added by a developer that is no longer part of the Simple Icons maintainers team. If someone want to bring a solution feel free to open a PR.

from simple-icons-font.

why have the composer package then? shrug

your readme will need updated because it suggests its one and done with composer. right now it says, install with composer, then see manual setup instructions. manual setup instructions say dl dist and link to css file. which does not exist in composer package. so why have the package if we are to just download the dist anyway. 🙃

from simple-icons-font.

alright, i'll hit up my composer buddies for suggestions before i submit an idea with a sledgehammer that could have been a screwdriver.

from simple-icons-font.

after discussing with some peeps about what we're used to seeing in our corner of the eco system i got back three main ideas. none of these are demands just what i got back in my polling.

1. my least fav - just not have the package. right now its a very goofy series of events where you would composer install and then download the release.zip. when you could just... download the release.zip. right now its got 37 downloads according to packagist.org, and at least 4 of them are me, so i don't forsee a swamping of issue tickets of people being like "what the hell" the rest of your life heheh.

2. amend the readme with more verbose how to for the less js front end toolchain inclined like us backenders. how do we go from cd vendor/simple-icons/simple-icons-font to having a working css and font file in there, etc.

3. my personal fav because it seems more common in my experience, so naturally the least convenient for you: change build practices such that you compile a dist dir, commit it, tag it, and you are done. no more ever uploading a release.zip, people just download the zip github will make and associate with that tag automatically. then the manual installers and the backend installers have everything they need. obviously i am not equipped to judge how this would mess with the npm normies. but yeah as a backend guy im pretty used to ninja'ing dist dirs from the repo and being done.

from simple-icons-font.

The solution is much more simpler but I don't have the motivation to do it testing it manually.

Just add a step to the publish workflow (after this step) to build the fonts before tagging the release, including the generated distribution folder (dist/) on the tag. After that, the fonts will be included in the Packagist package.

from simple-icons-font.