Koa2 implementation question about grant HOT 6 CLOSED

Last time I checked Grant was working fine with Koa2. Check out my comment here.

I know that support for generators will be dropped in Koa3 so I think that would be a breaking change here as well. Using async/await functions for your Koa routes shouldn't be a problem, it's just that Grant is going to use a generator function for its routes.

I'm usually fairly quick to respond and apply a patch if needed so you just have to let me know if something isn't working.

from grant.

mm, sorry, i'm not aware of any Koa3, did i miss something?

AFAIK, current version is v1 and it uses generators.
Next version is v2 and will be released (pretty soon) when Node will natively support async/await.
v2 does not allow generators middleware, everything should be async/await.

So when v2 released, will you support both versions or would async/await version replace generators one?

Thanks.

from grant.

Check out this section:

Old signature middleware (v1.x) support will be removed in v3

Koa v2.x will try to convert legacy signature, generator middleware on app.use, using koa-convert. It is however recommended that you choose to migrate all v1.x middleware as soon as possible.

From my prevous comment:

7a7e10c works for both Koa1.x and Koa2.x. For Koa2.x you have to update the koa-mount module to v2.x as well.

Again:

Grant currently works with both Koa1 and Koa2, however it won't work with Koa3 out of the box.

Let me know if something isn't working for you with Koa2.

from grant.

thanks for patience :)
will give it another try and reply with results

from grant.

works perfect!
was cooking it wrong.
thank you.

from grant.

No problem, thanks for the feedback!

from grant.