Git Product home page Git Product logo

Comments (11)

simonhauck avatar simonhauck commented on July 22, 2024

Thanks for the notification 👍

I updated the generated code. There were some more differences. For example some models were renamed, some additional exceptions were added.

Can you verify with this version, that everything works and give me feedback? Afterwards i would create a new release.
dependencies { implementation 'com.github.simonhauck:unofficial-nordigen-api-java:master-0228fea93e-1' }

from unofficial-nordigen-api-java.

marinkobabic avatar marinkobabic commented on July 22, 2024

from unofficial-nordigen-api-java.

marinkobabic avatar marinkobabic commented on July 22, 2024

It seems like ssn can't be anymore null even if it's defined as optional
"optional SSN field to verify ownership of the account"

from unofficial-nordigen-api-java.

marinkobabic avatar marinkobabic commented on July 22, 2024

I don't think this definition is correct https://github.com/simonhauck/unofficial-nordigen-api-java/blob/master/generated/src/main/java/com/github/simonhauck/unofficial/nordigen/api/PremiumApi.java

There are a lot of void responses. Where do you get the yaml file from, in order to generate the API? It seems like they have one here https://ob.nordigen.com/api/swagger.yaml but it's not valid.

from unofficial-nordigen-api-java.

simonhauck avatar simonhauck commented on July 22, 2024

I converted the json to yaml.
marinkobabic - but it's not valid.
And yes thats the main problem. The specification is not correct... thats what makes our life way harder.
I removed some optional fields, because somehow it lead to compile errors in the generated code.

I will try to revert that commit and resolve the issues in the next days :)
If you want to be proactive, you can also create a pull request :)

from unofficial-nordigen-api-java.

marinkobabic avatar marinkobabic commented on July 22, 2024

I will talk with Nordigen so that we can get here some support and an official yaml file. I did also some testing. When ssn is specified, then I'm getting a message that the selected bank is not supporting ssn. When setting ssn to null or empty string, then the error is reported that the field must be specified. Have reported this issue to Nordigen.

from unofficial-nordigen-api-java.

marinkobabic avatar marinkobabic commented on July 22, 2024

Just a hint. RequisitionV2 constains now the field SSN. Even if the value is not set in the code, but the serializer should create such a field with a null value, then the API call is failing. If the value null for this field is not sent over wire, then the request works. This means for you just make ssn field nullable: true before generating the code

from unofficial-nordigen-api-java.

simonhauck avatar simonhauck commented on July 22, 2024

sorry for the late reply (you know holidays and stuff :D )

So do i understand correctly. I should only add the nullable: true for the ssn field?

from unofficial-nordigen-api-java.

marinkobabic avatar marinkobabic commented on July 22, 2024

from unofficial-nordigen-api-java.

simonhauck avatar simonhauck commented on July 22, 2024

That would make this way easier 👍 Thanks!

i will try to resolve some other compilation errors and then i will notify you with a new version

from unofficial-nordigen-api-java.

simonhauck avatar simonhauck commented on July 22, 2024

can you please test again with com.github.simonhauck:unofficial-nordigen-api-java:3e3e0e223f

from unofficial-nordigen-api-java.

Related Issues (1)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.