Git Product home page Git Product logo

Comments (8)

vasole avatar vasole commented on May 16, 2024

@PiRK Review required.

from silx.

vasole avatar vasole commented on May 16, 2024

Not sure if it is an issue or not.

  • If Cython is installed on the machine, the generated code works.
  • If Cython is not installed on the machine, the supplied code does not work.

from silx.

PiRK avatar PiRK commented on May 16, 2024

I'll have a look at the cython issue. I probably need to adjust the list of source files in io/setup.py if os.environ["WITH_CYTHON"] == "False" is set in the general setup.py, to remove the pyx file and include the .c file.

from silx.

PiRK avatar PiRK commented on May 16, 2024

File extensions don't seem to be the problem, as fake_cythonize (https://github.com/silx-kit/silx/blob/master/setup.py#L296) already takes care of replacing .pyx with .c in the absence of cython.

from silx.

kif avatar kif commented on May 16, 2024

On Sun, 06 Mar 2016 23:43:17 -0800
Pierre Knobel [email protected] wrote:

File extensions don't seem to be the problem, as fake_cythonize (https://github.com/silx-kit/silx/blob/master/setup.py#L296) already takes care of replacing .pyx with .c in the absence of cython.

Look at the version of cython used and enforce the minimum version.

Armando, which version have you been using ?

from silx.

vasole avatar vasole commented on May 16, 2024
  • If I am not mistaken, I have been using cython > 0.17 in order to use memory views.
  • FreeART wraps more advanced C++ features and I think it needs 0.22 minimum.
  • I do not anticipate problems with the Cython version requirements if we make sure we distribute generated code.

from silx.

kif avatar kif commented on May 16, 2024

is this issue fixed ?

from silx.

PiRK avatar PiRK commented on May 16, 2024

We fixed the problem preventing building when cython isn't installed (#13). The previous issue related to not using os.path has also been also fixed (#10).

from silx.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.