Comments (11)
Looks like #261 will revert/fix this.
from ecs-deploy.
Hi @FarhadF. Thanks for opening this issue. Until this is resolved, you can use ecs-deploy version 3.10.2 to have the previous behavior.
The change to the current behavior was made in response to issue #249. @fillup, would you mind taking a look at these two issues to see how best to resolve both concerns?
from ecs-deploy.
This just caught me out too. Can we revert #249?
from ecs-deploy.
Hi @rpaterson. Sorry for the delay. This is on our radar, we just haven't managed to sort out whether reverting this would re-add a bug re: #249.
@Rishang, could you clarify what problem you were experiencing that #249 fixed for you? (We'll probably need to revert that change, so more information from you could help us do so in a way that doesn't re-add any problem you experienced.)
Thanks.
from ecs-deploy.
NUM_DEPLOYMENTS=$($AWS_ECS describe-services --services $SERVICE --cluster $CLUSTER | jq "[.services[].deployments[]] | length")
This was a variable in order to see if deployent gets to running healty sate, but previously it only check for single deployemnt, which should'nt be the case as if any service has more than 2 desired count it get fail in that case, so just had changed to heathcheck to be validate for 1 or more than one deployments as you can see in this change https://github.com/silinternational/ecs-deploy/pull/252/files
I don't think this can cause any issue, as i am using same code as my PR #252 in projects and is working well
from ecs-deploy.
@FarhadF can you check for the condition in function waitForGreenDeployment
for your code
from ecs-deploy.
I don't remember exactly and don't have easy access to an ECS cluster at the moment to test, but I don't think the deployment and the number of desired tasks are related. The check for desired count happens as part of updating the service in this section: https://github.com/silinternational/ecs-deploy/blob/develop/ecs-deploy#L454.
@forevermatt I'd recommend reverting #249.
@Rishang, if you can provide more details as to what you were seeing not working properly before that'd be helpful, but I don't believe the change you made is related the thing you're concerned with.
from ecs-deploy.
@fillup Thanks!
@FarhadF and @rpaterson, This has now been fixed and released as ecs-deploy 3.10.6 (also available via homebrew, if that's applicable to you)
from ecs-deploy.
Thank you!
from ecs-deploy.
what about the case where my minimum desired count for ecs service is 2 or more than one
from ecs-deploy.
Hi @Rishang. That line in ecs-deploy is checking the number of deployments, not the desired count for a service.
For example, when I run the related command...
aws ecs describe-services --services my-service-name --cluster my-cluster-name | jq "[.services[].deployments[]]"
... right now, I see a single result (thus length
is 1) which specifies a desiredCount of 2 (since I have that task definition running 2 instances of my container).
Was ecs-deploy doing something different than you expected? If you can provide us with some more details about that, we might be able to help resolve the problem you were experiencing.
Thanks.
from ecs-deploy.
Related Issues (20)
- --aws-instance-profile is not yet in use HOT 2
- Unknown parameter in input: "registeredAt" HOT 1
- [Help needed] Exit status code 255 HOT 2
- Support for ECS deployment circuit breaker
- Update service not triggering HOT 1
- Support for canary releases with EXTERNAL deployments HOT 2
- BUG: copy-task-definition-tags error when task def has no tags HOT 6
- Won't able to switch image in container within task definition HOT 1
- Deployment takes a tonne load of time to complete now HOT 2
- reset proxyConfiguration after deployment HOT 4
- Doesn't actually update the image HOT 2
- Force new deployment using latest task definition
- running in github actions HOT 2
- [Feature request] Use same taskdef for multiple deployments
- done update image other repo
- taskIds can have at most 100 items. HOT 2
- Run task Github actions input not used HOT 2
- Missing gha input for wait-for-success HOT 1
- ERROR: was unable to place a task. Reason: Capacity is unavailable at this time. Please try again later or in a different availability zone HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ecs-deploy.