Comments (1)
@varnerac Thanks for bringing this to our attention. This will be fixed in the next release. It turns out that this issue applies to other functions in the module, like exec
and execFile
. So this uncovered other bugs as well.
For now, I think the best way to implement this is to remove the encoding
option, since that can be set on the buffer itself for decoding to a string. This eliminates a lot of complexity caused by the polymorphic return type. This change will apply to all the affected functions.
from reason-nodejs.
Related Issues (16)
- Documentation needed
- Testing needed
- Conventions on Style, Techniques, Naming, etc.
- Factor out file permissions flag type? HOT 3
- Binding EventEmitter class for custom events HOT 14
- Abstract return type of callbacks HOT 8
- Make `Fs.Constants` abstract? HOT 6
- Doesnโt compile with bs-platform 8.2 HOT 2
- Stream objectMode implementation callbacks HOT 4
- Fs add bindings for callback implementations
- Examples should show namespace HOT 3
- ChildProcess incorrect types HOT 4
- `Fs.createWriteStreamOptions` returns wrong type HOT 1
- How to add `utf8` read option for the `Fs.readFileSync`? HOT 2
- How to create https server?
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. ๐๐๐
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google โค๏ธ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from reason-nodejs.