Comments (7)
Yea, so what happened here was this: That pull request, if I remember correctly, just changed the Podfile and revised the supported platforms. At that point, there was nothing iOS specific in the code. Then, several versions later, OAuth login support was added, and this specifically used the Cocoa Touch API.
Right now, the Podfile, and the OAuth login API are the only thing specifically preventing use on OSX.
One option I'd be open to would be to split the OAuth API into a second package. Have you looked at the code in depth? What were your thoughts on it?
from swiftddp.
Ah okay :) That makes sense. From a quick look it looks like the only iOS specific bit is the ViewController for the OAuth display.
I'm relatively new to building cross-platform frameworks in Swift, but my understanding is that you can include/exclude classes on a per platform basis as well using preprocessor statements to include sections of code based on the os:
http://nshipster.com/swift-system-version-checking/
So my guess is (and I'll try this out and see what happens) if we excluded the OAuth stuff from the build for the OSX target and used the preprocessor statements to exclude the OAuth methods from the API - then that would give us the framework minus the OAuth stuff on OS X.
from swiftddp.
Sounds good to me.
from swiftddp.
My last PR #69 created the scheme. Which excluded the oauth in the code until it can be added back in.
I haven't tested it, though you should be able to tweak it
from swiftddp.
Awesome. I'll have to give it a go. If you get around to testing it, that would be a big help also, as i'm tied up with other work at the moment.
from swiftddp.
I was commenting more for the issue owner. So they can be equipped to do
it.
I'm tied up for the next couple weeks also
On Aug 27, 2016 12:30 PM, "Peter Siegesmund" [email protected]
wrote:
Awesome. I'll have to give it a go. If you get around to testing it, that
would be a big help also, as i'm tied up with other work at the moment.—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#60 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAqKL6KC3S47IUUuBWS1R2KiNrNyLhKyks5qkHQqgaJpZM4JURRk
.
from swiftddp.
Ah, ok. Thanks.
from swiftddp.
Related Issues (20)
- Keep sending request to server HOT 3
- subscribe observer
- Duplication HOT 1
- outdated CryptoSwift dependency HOT 4
- How to get info user?
- make custom id
- Swift 4 errors HOT 7
- Not able to compile on xcode9.4 with swift 4.1 HOT 1
- [Question] How can I use SwiftDDP in a command line tool? HOT 1
- Cocoapods version of the podspec file IS NOT up to date with the current version on GitHub HOT 2
- Unsupported version requirements in SwiftDDP.podspec HOT 4
- Xcode10/swift4 support HOT 1
- Unencrypted connection (ws://) throws 'SSLHandshake failed' HOT 1
- Unable to build after adding pod for Swift DDP in podfile for Xcode 10.1 and Swift 4.2.
- login meteor server with native facebook sdk in iOS ? HOT 1
- Doesn't build with new xcode HOT 2
- How to receive subscription with message and error log
- Expired Meteor login tokens are not being handled correctly HOT 1
- Ambiguous us of 'init(callback:)' HOT 4
- how To Access Direct Local database. without Creating Collections
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from swiftddp.