Support for OS X about swiftddp HOT 7 CLOSED

Yea, so what happened here was this: That pull request, if I remember correctly, just changed the Podfile and revised the supported platforms. At that point, there was nothing iOS specific in the code. Then, several versions later, OAuth login support was added, and this specifically used the Cocoa Touch API.

Right now, the Podfile, and the OAuth login API are the only thing specifically preventing use on OSX.

One option I'd be open to would be to split the OAuth API into a second package. Have you looked at the code in depth? What were your thoughts on it?

from swiftddp.

Ah okay :) That makes sense. From a quick look it looks like the only iOS specific bit is the ViewController for the OAuth display.

I'm relatively new to building cross-platform frameworks in Swift, but my understanding is that you can include/exclude classes on a per platform basis as well using preprocessor statements to include sections of code based on the os:

http://nshipster.com/swift-system-version-checking/

So my guess is (and I'll try this out and see what happens) if we excluded the OAuth stuff from the build for the OSX target and used the preprocessor statements to exclude the OAuth methods from the API - then that would give us the framework minus the OAuth stuff on OS X.

from swiftddp.

Sounds good to me.

from swiftddp.

My last PR #69 created the scheme. Which excluded the oauth in the code until it can be added back in.

I haven't tested it, though you should be able to tweak it

from swiftddp.

Awesome. I'll have to give it a go. If you get around to testing it, that would be a big help also, as i'm tied up with other work at the moment.

from swiftddp.

I was commenting more for the issue owner. So they can be equipped to do
it.

I'm tied up for the next couple weeks also

On Aug 27, 2016 12:30 PM, "Peter Siegesmund" [email protected]
wrote:

Awesome. I'll have to give it a go. If you get around to testing it, that
would be a big help also, as i'm tied up with other work at the moment.

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#60 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAqKL6KC3S47IUUuBWS1R2KiNrNyLhKyks5qkHQqgaJpZM4JURRk
.

from swiftddp.

Ah, ok. Thanks.

from swiftddp.