coding join_df_list about sidora.core HOT 8 CLOSED

OK. Wow. This is actually very clever. So I tried join_df_list(df_list_1) and it gives back a tibble with 117 columns, merging through the entire cascade. Very cool!

from sidora.core.

Hm - you're right - modifying the input list is a little bit hacky, but I think it's not so bad here, given the sequential merging procedure.

My implementation allows to merge multiple tables at once, not just two. And I would argue that this is a key feature.

from sidora.core.

Ah... OK, I expected I must have missed something... so it merges all pairs that are in direct sequence?

from sidora.core.

Yes. And that's why we need check_completeness(). The merging cascade breaks if an intermediate pair is missing.

This is also just a prototype at the moment. Doesn't include other tables beyond "TAB_Site", "TAB_Individual", "TAB_Sample", "TAB_Extract", "TAB_Library".

from sidora.core.

OK, cool. Good that I didn't go straight for a PR then.

from sidora.core.

Check out this example code:

creds <- readLines("playground/.credentials")
con <- DBI::dbConnect(
  RMySQL::MySQL(), 
  host = creds[1],
  user = creds[2],
  password = creds[3],
  db = "pandora"
)

df_list_1 <- get_df_list(c(
  "TAB_Site", "TAB_Individual", "TAB_Sample", "TAB_Extract", "TAB_Library"
), con = con)

join_df_list(df_list_1)

df_list_2 <- get_df_list(c(
  "TAB_Site", "TAB_Individual"
), con = con)

join_df_list(df_list_2)

df_list_3 <- get_df_list(c(
  "TAB_Site", "TAB_Extract"
), con = con)

join_df_list(df_list_3)

from sidora.core.

I also misunderstood R's in-place modify. I now remember having read in advanced R that in-place modify of lists creates duplicates, so this may be hacky but actually save, I think.

from sidora.core.

Is this issue still relevant or can we close it @stschiff?

from sidora.core.