Git Product home page Git Product logo

Comments (9)

sidneys avatar sidneys commented on August 13, 2024 1

@hexion Thanks for the heads-up. However, we need more information about the environment (operating system, version) and the app (version, installation) for an assessment of the issue. Please add your "steps to reproduce". Cheers!

from desktop-dimmer.

hexion avatar hexion commented on August 13, 2024 1

I'm running Ubuntu 16.04, with the gnome-flashback desktop environment.

I'm not sure right now if the menu bar is set to bottom by default, it might be at the top. To change it, press down Super+Alt+Right click on the menu bar, a menu will appear, select Properties. Then there is an option to change the layout.

As for reproducible steps, simply run the application on a system with a menu bar positioned at the bottom, and click on the app menu icon. The window with the sliding bar will appear at the top of the screen, far from the menu icon.

Thanks for looking into it.

from desktop-dimmer.

sidneys avatar sidneys commented on August 13, 2024 1

@hexion
This issue was recently resolved, but only tested on Windows. Please test and share your findings.

from desktop-dimmer.

hexion avatar hexion commented on August 13, 2024 1

Clicking on the icon will now cause a stack trace:

Uncaught Exception:
TypeError: Cannot read property 'substr' of undefined
at showWindow (/opt/Desktop Dimmer/resources/app.asar/node_modules/menubar/index.js:150:76)
at Tray.clicked (/opt/Desktop Dimmer/resources/app.asar/node_modules/menubar/index.js:101:7)
at emitTwo (events.js:106:13)
at Tray.emit (events.js:191:7)

Hope that helps

from desktop-dimmer.

sidneys avatar sidneys commented on August 13, 2024 1

@hexion
Thanks for the detailed logs. We tried a new approach which contains a workaround for the menu positioning issues, which is a upstream Electron issue (limited functional support for Linux task bars).

Can you please test & share your findings from the latest release v2.8.8?
Cheers.

from desktop-dimmer.

hexion avatar hexion commented on August 13, 2024 1

Same stack trace upon click with version 2.8.8:

Uncaught Exception:
TypeError: Cannot read property 'substr' of undefined
at showWindow (/opt/Desktop Dimmer/resources/app.asar/node_modules/menubar/index.js:150:76)
at Tray.clicked (/opt/Desktop Dimmer/resources/app.asar/node_modules/menubar/index.js:101:7)
at emitTwo (events.js:106:13)
at Tray.emit (events.js:191:7)

Btw, I noticed this other enhancement request:
#8

IMHO, that would indirectly solve this issue. Sure, the app wouldn't automatically detect bottom task bars, but the user could just place it wherever he likes and as long as the window is drawn at the newly saved location, it would all be fine.

from desktop-dimmer.

sidneys avatar sidneys commented on August 13, 2024 1

@hexion
Thanks for the quick test iterations. New version with changed menubar module is available: v2.9.0
Keep the reports coming, this really is not reproducible on our testbed running Ubuntu 16.10 /w Unity 7

from desktop-dimmer.

hexion avatar hexion commented on August 13, 2024 1

No problem. With 2.9.0 there are no crashes. The popup window now has moved a bit to the left. It now shows up at the right top of the screen with an offset of about 200px to the left.

This may help. There is a command that can retrieve certain values for gnome-panel so, in environments that use it, will tell you where it is in the screen.

$ dconf read /org/gnome/gnome-panel/layout/toplevels/top-panel/orientation
'bottom'
$ dconf read /org/gnome/gnome-panel/layout/toplevels/top-panel/size
24
$ dconf read /org/gnome/gnome-panel/layout/toplevels/top-panel/y
1056

The last 2 values are in pixels.

from desktop-dimmer.

sidneys avatar sidneys commented on August 13, 2024

Thanks for your reports. As the issue has been resolved, i'm closing this issue.

Please feel free to open a new issue if the issue should reoccur.

Cheers,
S

from desktop-dimmer.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.