Comments (3)
A third option would be to remove the Dockerfile. The current file is not functional, which gives a bad first impression to the docker-inclined folks out there (that includes me). If this option is not chosen, I would like to add a travis task to verify the Dockerfile can actually be built.
from shuup.
Yeah I think the problematic thing here is the npm build. Even if it went through, the build will take some time and it also seems to get stuck pretty easily.
As a fourth option I would suggest to build the image from latest release wheel. That would make things fast and more reliable.
I am happy to accept this change to the Dockerfile. Also with good reasoning I can accept other solutions too, I don't see any need for the virtualenv so maybe the option 1 could be ok.
In case you are not interested to continue with this we will probably do the wheel change later, but for now fixing this is not highest priority for us.
from shuup.
+1
from shuup.
Related Issues (20)
- Contact
- npm build failes on windows
- Error in docker HOT 5
- Unable to make the APIs work. No module name shuup.api found
- Okay
- django-enumfields==2.0.0 gives AttributeError: '_EnumDict' object has no attribute '_cls_name'
- GDPR - shuup_mutaddress rows not anonymized
- Anonymizing a Contact anonymizes Admin as well
- GDPR - Download Data button doesnโt return any data
- Command "python setup.py egg_info" failed with error code 1 in /tmp/pip-install-07on5v5j/cairocffi/ HOT 2
- JavaScript Files are not loading in Shuup Admin
- Add SECURITY.md HOT 3
- Default products are not visible on home page. HOT 1
- Error while docker-compose up HOT 2
- Is shuup public repo dead ? HOT 1
- Add Contributing.md
- Add a code of conduct.md
- can't docker-compose up
- Shuup Still Active? HOT 3
- The Multi vendor Addon HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. ๐๐๐
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google โค๏ธ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from shuup.