Git Product home page Git Product logo

Comments (3)

kvdveer avatar kvdveer commented on May 21, 2024

A third option would be to remove the Dockerfile. The current file is not functional, which gives a bad first impression to the docker-inclined folks out there (that includes me). If this option is not chosen, I would like to add a travis task to verify the Dockerfile can actually be built.

from shuup.

tulimaki avatar tulimaki commented on May 21, 2024

Yeah I think the problematic thing here is the npm build. Even if it went through, the build will take some time and it also seems to get stuck pretty easily.

As a fourth option I would suggest to build the image from latest release wheel. That would make things fast and more reliable.

I am happy to accept this change to the Dockerfile. Also with good reasoning I can accept other solutions too, I don't see any need for the virtualenv so maybe the option 1 could be ok.

In case you are not interested to continue with this we will probably do the wheel change later, but for now fixing this is not highest priority for us.

from shuup.

lupa18 avatar lupa18 commented on May 21, 2024

+1

from shuup.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.