REPLY_MULTY_BULK Bug in Command/Abstract.php? about rediska HOT 7 CLOSED

Hi. What version of Redis you are use? I can't repoduce this bug. If no one keys is matched Redis reply is $0.

from rediska.

Hi again - my apologies, I am using redis 1.3.4 cloned/compiled from github 2 days ago. I guess I thought the implementation of already added commands wouldn't change that much but it seems that the results haven't, but the output responses have.

For clarity, the response I get from the server is *0 currently on redis v1.3.4.

Maybe I should revert to a released version of redis for now, however it does raise the question about whether its a good idea for redis clients to support different commands implementations depending on which version of redis you are connected to (this is found with INFO command).

Thanks,

Ryan

from rediska.

It's a good idea by very much of work :), and INFO on every connection is overhead as im think. I will be very happy, if you wanna realase this feature.

from rediska.

Confirmed - i installed redis 1.2.5 and this 'issue' is no longer a problem.

I agree doing INFO on every connection is an overhead, and not a good idea. Perhaps then it could be a configuration variable when you instantiate Rediska?

However, I agree it would probably be quite a lot of work to add into a single Rediska release. Maybe it would benefit everyone if Rediska was branched when a new major version of Redis came out?
That way it will make it easier for a developer to know which Rediska will work with which Redis - as the right commands/responses will apply to that client/server version.

What do you think?

Thanks,

Ryan

from rediska.

Branches is not a good idea too. Becouse if you have fix for all versions of Redis you need fix in all branches it will be a nightmare %).

I think good idea implement dependenses of commands and redis server versions in Rediska.

from rediska.

Now for you application with Redis 1.3.4 you may overwrite any commands with methods Rediska::addCommand and Rediska::removeCommand

from rediska.

And Rediska has own issue tracker http://bugs.geometria-lab.net/projects/rediska/issues %)

from rediska.